write happy path tests for automation23 registrar registerUpkeep() #12474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
|
Go solidity wrappers are out-of-date, regenerate them via the |
| @@ -14,7 +15,116 @@ contract SetUp is BaseTest { | |||
| function setUp() public override { | |||
| super.setUp(); | |||
| (registry, registrar) = deployAndConfigureAll(); | |||
| vm.stopPrank(); // reset identity at the start of each test | |||
|
Go solidity wrappers are out-of-date, regenerate them via the |
RyanRHall
force-pushed
the
foundry-registrar-2-3-tests
branch
from
aca91d8
to
97a9dfe
Compare
RyanRHall
force-pushed
the
foundry-registrar-2-3-tests
branch
from
97a9dfe
to
2efb55c
Compare
|
FelixFan1992
approved these changes
Mar 19, 2024
shileiwill
reviewed
Mar 19, 2024
| @@ -60,6 +65,9 @@ contract BaseTest is Test { | |||
| USDTOKEN_USD_FEED = new MockV3Aggregator(8, 100_000_000); // $1 | |||
| FAST_GAS_FEED = new MockV3Aggregator(0, 1_000_000_000); // 1 gwei | |||
|
|
|||
| TARGET1 = new MockUpkeep(); | |||
| TARGET2 = new MockUpkeep(); | |||
There was a problem hiding this comment.
nit, TARGET2 is not used anywhere.
Code LGTM. let me know when you are ready, will stamp again.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 27, 2024
…12474) * write happy path tests for automation23 registrar registerUpkeep() * regerate wrappers * rename UpkeepMock --> MockUpkeep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.