Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRF-949-Missing-onlyConfiguredNotDisabled-Modifier #12482

Merged
merged 1 commit into from
Mar 19, 2024
Merged

VRF-949-Missing-onlyConfiguredNotDisabled-Modifier #12482

merged 1 commit into from
Mar 19, 2024

Conversation

leeyikjiun
Copy link
Contributor

Add missing onlyConfiguredNotDisabled modifier to VRFV2PlusWrapper requestRandomWordsInNative

@leeyikjiun leeyikjiun requested review from a team as code owners March 19, 2024 08:11
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ibrajer
ibrajer approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ibrajer ibrajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leeyikjiun leeyikjiun added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@leeyikjiun leeyikjiun added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 19, 2024
@kidambisrinivas kidambisrinivas changed the title VRF-949-Audit-Fix-SP-6-Missing-onlyConfiguredNotDisabled-Modifier VRF-949-Missing-onlyConfiguredNotDisabled-Modifier Mar 19, 2024
Merged via the queue into develop with commit 1580082 Mar 19, 2024
116 of 117 checks passed
@kidambisrinivas kidambisrinivas deleted the VRF-949-Audit-Fix-SP-6-Missing-onlyConfiguredNotDisabled-Modifier branch March 19, 2024 12:09
kidambisrinivas pushed a commit that referenced this pull request Mar 27, 2024
@leeyikjiun @kidambisrinivas
Add missing modifier to vrfv2pluswrapper requestRandomWordsInNative (#…
8da217e 
…12482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrajer ibrajer ibrajer approved these changes

@kidambisrinivas kidambisrinivas kidambisrinivas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leeyikjiun @kidambisrinivas @ibrajer