Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRF-951-Missing-Zero-Address-Check #12483

Merged
merged 3 commits into from
Mar 19, 2024
Merged

VRF-951-Missing-Zero-Address-Check #12483

merged 3 commits into from
Mar 19, 2024

Conversation

leeyikjiun
Copy link
Contributor

Add missing zero address check in VRFConsumerBaseV2Plus

@leeyikjiun leeyikjiun requested review from a team as code owners March 19, 2024 08:57
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

ibrajer
ibrajer previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ibrajer ibrajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kidambisrinivas
Copy link
Collaborator

kidambisrinivas commented Mar 19, 2024 •
edited
Loading

Could you run pnpm install; pnpm changeset from the root dir of the repo. That should fix the changeset checker. Optional though. The CI job does not seem to be a Required check.

@kidambisrinivas kidambisrinivas changed the title VRF-951-Audit-Fix-SP-8-Missing-Zero-Address-Check VRF-951-Missing-Zero-Address-Check Mar 19, 2024
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 19, 2024
@kidambisrinivas kidambisrinivas removed this pull request from the merge queue due to a manual request Mar 19, 2024
@kidambisrinivas kidambisrinivas dismissed stale reviews from ibrajer and themself via e9625a0 March 19, 2024 12:13
@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@leeyikjiun leeyikjiun added this pull request to the merge queue Mar 19, 2024
Merged via the queue into develop with commit 27087ca Mar 19, 2024
116 of 117 checks passed
@leeyikjiun leeyikjiun deleted the VRF-951-Audit-Fix-SP-8-Missing-Zero-Address-Check branch March 19, 2024 13:02
@leeyikjiun leeyikjiun mentioned this pull request Mar 20, 2024
Merged
kidambisrinivas added a commit that referenced this pull request Mar 27, 2024
@leeyikjiun @kidambisrinivas
VRF-951-Missing-Zero-Address-Check (#12483)
cdb85e4 
* Add missing zero address check in VRFConsumerBaseV2Plus

* Updated go wrappers

---------

Co-authored-by: Sri Kidambi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljapavlovs iljapavlovs iljapavlovs approved these changes

@kidambisrinivas kidambisrinivas kidambisrinivas left review comments

@ibrajer ibrajer ibrajer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leeyikjiun @kidambisrinivas @ibrajer @iljapavlovs