Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funds refund fixes and optimisation #12485

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Funds refund fixes and optimisation #12485

merged 2 commits into from
Mar 19, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Mar 19, 2024

  • dockeignore go work
  • use transfer gas fee not gas limit for sending funds (they are orders of magnitude different)
  • no fail fast for funds return

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@Tofel Tofel marked this pull request as ready for review March 19, 2024 11:09
@Tofel Tofel requested a review from a team as a code owner March 19, 2024 11:09
@skudasov skudasov added this pull request to the merge queue Mar 19, 2024
Merged via the queue into develop with commit b790f6c Mar 19, 2024
105 checks passed
@skudasov skudasov deleted the funds_refund_fixes_and_optimisation branch March 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tofel @skudasov