Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc changes #12489

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Misc changes #12489

merged 6 commits into from
Mar 20, 2024

Conversation

kidambisrinivas
Copy link
Collaborator

@kidambisrinivas kidambisrinivas commented Mar 19, 2024 •
edited
Loading

Updates

  • Misc contract changes
    • Reuse struct RequestCommitmentV2Plus from VRFTypes
    • Fix interface name IVRFCoordinatorV2PlusFulfill in BatchVRFCoordinatorV2Plus to avoid confusion with IVRFCoordinatorV2Plus.sol
    • Remove unused errors
    • Rename variables for readability
    • Fix comments
    • Minor gas optimisation (++i)
  • Fix integration tests

@kidambisrinivas kidambisrinivas requested review from a team as code owners March 19, 2024 15:51
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@kidambisrinivas kidambisrinivas requested a review from a team as a code owner March 19, 2024 17:44
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Mar 20, 2024
Merged via the queue into develop with commit 3a49094 Mar 20, 2024
117 checks passed
@kidambisrinivas kidambisrinivas deleted the VRF-952-misc-changes branch March 20, 2024 10:42
kidambisrinivas added a commit that referenced this pull request Mar 27, 2024
@kidambisrinivas
Misc changes (#12489)
926b161 
* Misc changes

* Minor fix

* Reuse RequestCommitmentV2Plus, fix interface name, integration tests fix

* Updated changesets

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinhoonbang jinhoonbang jinhoonbang approved these changes

@leeyikjiun leeyikjiun leeyikjiun approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kidambisrinivas @leeyikjiun @jinhoonbang