Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed limitTransfer gasLimit from uint32 to uint64 #12496

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Changed limitTransfer gasLimit from uint32 to uint64 #12496

merged 2 commits into from
Mar 21, 2024

Conversation

silaslenihan
Copy link
Contributor

No description provided.

@silaslenihan silaslenihan requested review from a team as code owners March 19, 2024 19:55
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from a101add to 81764ac Compare March 19, 2024 20:42
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from ed38172 to 84e705c Compare March 19, 2024 21:03
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from aef0b34 to 372135b Compare March 19, 2024 23:14
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from 9347d71 to 7d45266 Compare March 20, 2024 14:23
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from 886263f to e07b62f Compare March 20, 2024 17:42
amit-momin
amit-momin previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

dimriou
dimriou previously approved these changes Mar 20, 2024
View reviewed changes
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from 32b6f86 to 7740856 Compare March 21, 2024 13:41
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from 524a4e5 to fd96643 Compare March 21, 2024 15:00
@silaslenihan silaslenihan force-pushed the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch from fd96643 to fc82979 Compare March 21, 2024 15:12
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 3135047 Mar 21, 2024
104 checks passed
@prashantkumar1982 prashantkumar1982 deleted the BCI-2740-Change-node-LimitTransfer-from-uint32-to-uint64 branch March 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@amit-momin amit-momin amit-momin left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silaslenihan @dimriou @prashantkumar1982 @amit-momin