-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Agnostic MultiNode + EVM Implementation #13386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-client Implement RPCClient Interface
… into BCI-3160-EVM-MultiNode-PoC
WF: CI Core#d5ce6f2No errors found in this run. 🎉 |
dhaidashenko
reviewed
Oct 6, 2024
dhaidashenko
reviewed
Oct 6, 2024
dhaidashenko
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Quality Gate passedIssues Measures |
reductionista
approved these changes
Oct 15, 2024
patrick-dowell
approved these changes
Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain Agnostic Multinode
Implemented new Chain Agnostic MultiNode design to enable the scaleability of MultiNode to nonEVM chains.
Design Doc: https://docs.google.com/document/d/1nvgelqk4xbznRy8zdy_KHeEjFjgKkqhSUGXSlDze7nU/edit#heading=h.4e7ng0tekbkc
The MultiNode now has reduced responsibility to simple do the following:
Chain specific implementations will now call RPC methods directly, while MultiNode just provides which RPC to use.
Benefits
Common Components / Interfaces
EVM Implementation
An EVM specific RpcClient was implemented, and the EVM Chain Client was modified to initialize the new MultiNode and TransactionSender for EVM. The client is now responsible for calling RPC methods after asking MultiNode for an RPC to use.