Aptos (combined branch)

[archseer]

Contains #14076, #14078 and staged changes

[archseer]

Perhaps all this can be moved into InitAptos?

[bolekk]

I like having this merged as an example trigger. I only wish it could go to common but it can't because of EVM dep :( Maybe we should create a special sub-directory with example capabilities and move on-demand trigger there as well...? @cedric-cordenier thoughts?

[bolekk]

Testing where? Can it be under some flag? It doesn't seem right to always add it.

[archseer]

I'll move this inside the mock_trigger.go, that way it's only used if the capability is used

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Integer overflow conversion int -> uint8:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:76:20: G115: integer overflow conversion int -> uint8 (gosec)
		bytes[31] = uint8(i + 1)
		 ^

**Why**: This error occurs because converting an `int` to `uint8` can cause an overflow if the `int` value exceeds the range of `uint8`.

Suggested fix: Ensure that the int value being converted to uint8 is within the range of uint8 (0 to 255) or use a type that can handle larger values.

2. Integer overflow conversion int64 -> uint32:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:143:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	Timestamp: uint32(timestamp),
	 ^
core/capabilities/streams/mock_trigger.go:144:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	ValidFromTimestamp: uint32(timestamp),
	 ^
core/capabilities/streams/mock_trigger.go:149:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	ExpiresAt: uint32(timestamp + 1000000),
	 ^

**Why**: This error occurs because converting an `int64` to `uint32` can cause an overflow if the `int64` value exceeds the range of `uint32`.

Suggested fix: Ensure that the int64 value being converted to uint32 is within the range of uint32 (0 to 4,294,967,295) or use a type that can handle larger values.

3. Integer overflow conversion int -> uint32:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:186:94: G115: integer overflow conversion int -> uint32 (gosec)
	reportCtx := ocrTypes.ReportContext{ReportTimestamp: ocrTypes.ReportTimestamp{Epoch: uint32(baseTimestamp + j)}}
	 ^

**Why**: This error occurs because converting an `int` to `uint32` can cause an overflow if the `int` value exceeds the range of `uint32`.

Suggested fix: Ensure that the int value being converted to uint32 is within the range of uint32 (0 to 4,294,967,295) or use a type that can handle larger values.

4. Replace prices[i] = prices[i] + 1 with prices[i]++:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:178:4: assignOp: replace `prices[i] = prices[i] + 1` with `prices[i]++` (gocritic)
	prices[i] = prices[i] + 1
	^

**Why**: This error occurs because the `prices[i] = prices[i] + 1` operation can be simplified to `prices[i]++`.

Suggested fix: Replace prices[i] = prices[i] + 1 with prices[i]++.

5. Receiver name should be consistent:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:114:1: receiver-naming: receiver name o should be consistent with previous receiver name m for MockTriggerService (revive)
func (o *MockTriggerService) RegisterTrigger(ctx context.Context, req capabilities.TriggerRegistrationRequest) (<-chan capabilities.TriggerResponse, error) {
	ch, err := o.MercuryTriggerService.RegisterTrigger(ctx, req)
	if err != nil {
		return nil, err
	}
	config, _ := o.MercuryTriggerService.ValidateConfig(req.Config)
	o.subscribersMu.Lock()
	defer o.subscribersMu.Unlock()
	o.subscribers[req.Metadata.WorkflowID] = config.FeedIds
	return ch, nil
}
core/capabilities/streams/mock_trigger.go:127:1: receiver-naming: receiver name o should be consistent with previous receiver name m for MockTriggerService (revive)
func (o *MockTriggerService) UnregisterTrigger(ctx context.Context, req capabilities.TriggerRegistrationRequest) error {
	err := o.MercuryTriggerService.UnregisterTrigger(ctx, req)
	o.subscribersMu.Lock()
	defer o.subscribersMu.Unlock()
	delete(o.subscribers, req.Metadata.WorkflowID)
	return err
}

**Why**: This error occurs because the receiver name `o` is inconsistent with the previous receiver name `m` for `MockTriggerService`.

Suggested fix: Use a consistent receiver name for all methods of MockTriggerService.

6. Unnecessary trailing newline:[Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:216:3: unnecessary trailing newline (whitespace)

^

**Why**: This error occurs because there is an unnecessary trailing newline in the code.

Suggested fix: Remove the unnecessary trailing newline.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
11.67% Technical Debt Ratio on New Code (required ≤ 4%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint