Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix benchmark test namespace name (AUTO-11113) #13729

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix benchmark test namespace name (AUTO-11113) #13729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-tests/benchmark/keeper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func SetupAutomationBenchmarkEnv(t *testing.T, keeperTestConfig types.KeeperBenc
TTL: time.Hour * 720, // 30 days,
NamespacePrefix: fmt.Sprintf(
"automation-%s-%s-%s",
strings.ToLower(strings.Join(keeperTestConfig.GetConfigurationNames(), "_")),
strings.ToLower(strings.Join(keeperTestConfig.GetConfigurationNames(), "")),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not use multiple named configs. To keep the namespace naming consistent to as it was before, joining is being done without any separators.

strings.ReplaceAll(strings.ToLower(testNetwork.Name), " ", "-"),
strings.ReplaceAll(strings.ToLower(*keeperTestConfig.GetKeeperConfig().Common.RegistryToTest), "_", "-"),
),
Expand Down
Loading