Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: skip setting EVM networks on nodes in nonEVM e2e tests #13768

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

aalu1418
Copy link
Contributor

@aalu1418 aalu1418 commented Jul 5, 2024

Current e2e tests add EVM networks to nonEVM test runs. And by adding EVM networks it overrides any previous changes to the base config related to EVM networks.

Using EVM networks on nonEVM runs leads to flakes because the EVM networks may not respond in time and the nodes will throw unrelated error logs for EVM issues in a nonEVM e2e test.

Requires Dependencies

Copy link
Contributor

github-actions bot commented Jul 5, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found - Please include it in the PR title or in a commit message.

@aalu1418 aalu1418 changed the title e2e: skip setting EVM networks in nonEVM e2e tests e2e: skip setting EVM networks on nodes in nonEVM e2e tests Jul 5, 2024
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
108.89% Technical Debt Ratio on New Code (required ≤ 4%)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

smickovskid
smickovskid previously approved these changes Jul 8, 2024
@aalu1418 aalu1418 marked this pull request as ready for review July 8, 2024 13:19
@aalu1418 aalu1418 requested review from a team as code owners July 8, 2024 13:19
@aalu1418 aalu1418 requested a review from smickovskid July 8, 2024 13:19
@jmank88 jmank88 added this pull request to the merge queue Jul 8, 2024
Merged via the queue into develop with commit 39ce0ec Jul 8, 2024
113 of 114 checks passed
@jmank88 jmank88 deleted the fix-solana-e2e-test-evm-flakiness branch July 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants