integrate beholder client #14110
Merged
integrate beholder client #14110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
beholder-client
branch
from
0716109
to
dbc1895
Compare
patrickhuie19
previously approved these changes
Aug 14, 2024
jmank88
force-pushed
the
beholder-client
branch
4 times, most recently
from
556c971
to
1e9d3eb
Compare
jmank88
commented
Aug 20, 2024
jmank88
force-pushed
the
beholder-client
branch
2 times, most recently
from
f9c428f
to
1b9b490
Compare
jmank88
force-pushed
the
beholder-client
branch
4 times, most recently
from
f248689
to
21244c5
Compare
jmank88
force-pushed
the
beholder-client
branch
7 times, most recently
from
17c07c2
to
fad1ee9
Compare
jmank88
force-pushed
the
beholder-client
branch
8 times, most recently
from
d6dc83e
to
cbfe80c
Compare
pkcll
reviewed
Sep 10, 2024
pkcll
reviewed
Sep 10, 2024
pkcll
previously approved these changes
Sep 10, 2024
jmank88
force-pushed
the
beholder-client
branch
from
cbfe80c
to
68bafd9
Compare
jmank88
force-pushed
the
beholder-client
branch
2 times, most recently
from
39ee9d8
to
a79b1da
Compare
| err = multierr.Append(err, configutils.ErrInvalid{Name: "RootDir", Value: true, Msg: fmt.Sprintf("Failed to expand RootDir. Please use an explicit path: %s", verr)}) | ||
| } | ||
|
|
||
| if (*c.OCR.Enabled || *c.OCR2.Enabled) && !*c.P2P.V2.Enabled { | ||
| err = multierr.Append(err, configutils.ErrInvalid{Name: "P2P.V2.Enabled", Value: false, Msg: "P2P required for OCR or OCR2. Please enable P2P or disable OCR/OCR2."}) | ||
| } | ||
|
|
||
| if *c.Tracing.Enabled && *c.Telemetry.Enabled { |
There was a problem hiding this comment.
If both are enabled will there be a clash over how the globally registered tracing provider is set?
There was a problem hiding this comment.
No, TraceSpanExporter is used to register a second exporter.
I did notice an issue with the attributes merge though. Fix incoming.
There was a problem hiding this comment.
Common fix here: smartcontractkit/chainlink-common#763
jmank88
force-pushed
the
beholder-client
branch
from
a79b1da
to
f32d9a7
Compare
|
patrickhuie19
approved these changes
Sep 11, 2024
pkcll
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies