auto: fix chain module #14140
auto: fix chain module #14140
Conversation
|
I see you updated files related to |
|
I see you updated files related to
|
| @@ -11,7 +11,7 @@ interface IChainModule { | |||
| // retrieve the L1 data fee for a L2 transaction. it should return 0 for L1 chains and | |||
| // L2 chains which don't have L1 fee component. it uses msg.data to estimate L1 data so | |||
| // it must be used with a transaction. Return value in wei. | |||
| function getCurrentL1Fee() external view returns (uint256); | |||
| function getCurrentL1Fee(uint256 dataSize) external view returns (uint256); | |||
There was a problem hiding this comment.
option 2 is use a bytes here. but that makes L1 fee calculation extremely costly and that's what we try to avoid
| @@ -16,7 +16,7 @@ contract OptimismModule is ChainModuleBase { | |||
| uint256 private constant FIXED_GAS_OVERHEAD = 60_000; | |||
| uint256 private constant PER_CALLDATA_BYTE_GAS_OVERHEAD = 270; | |||
|
|
|||
| function getCurrentL1Fee() external view override returns (uint256) { | |||
| function getCurrentL1Fee(uint256) external view override returns (uint256) { | |||
There was a problem hiding this comment.
using uint256 will make it not accurate
using bytes will make it waste lots of gas
There was a problem hiding this comment.
- passing bytes into this function
- concat this bytes with a padding
- passing the concated bytes to getL1Fee
with chain module (uint256) and V2: nothing
with chain module (bytes) and V2: 1 (BASE, OP), 1/2/3 (Scroll)
|
Requires Dependencies
Resolves Dependencies