devsvcs-168: fix chain module l1 fee calculation #14150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
FelixFan1992
commented
Aug 19, 2024
|
ibrajer
reviewed
Aug 20, 2024
ibrajer
reviewed
Aug 20, 2024
ibrajer
approved these changes
Aug 20, 2024
KuphJr
reviewed
Aug 20, 2024
infiloop2
reviewed
Aug 21, 2024
| return SCROLL_ORACLE.getL1Fee(bytes.concat(msg.data, SCROLL_L1_FEE_DATA_PADDING)); | ||
| constructor() ConfirmedOwner(msg.sender) {} | ||
|
|
||
| function getCurrentL1Fee(uint256 dataSize) external view override returns (uint256) { |
There was a problem hiding this comment.
have we tested this function on scroll to see if it is charging reasonably?
There was a problem hiding this comment.
yes. i did some testing with a custom upkeep and this module.
i think we can start with 100 as the coefficient and reduce it to a comfortable number
infiloop2
reviewed
Aug 21, 2024
infiloop2
reviewed
Aug 21, 2024
| @@ -3,8 +3,12 @@ pragma solidity 0.8.19; | |||
|
|
|||
| import {IScrollL1GasPriceOracle} from "../../vendor/@scroll-tech/contracts/src/L2/predeploys/IScrollL1GasPriceOracle.sol"; | |||
| import {ChainModuleBase} from "./ChainModuleBase.sol"; | |||
| import {ConfirmedOwner} from "../../shared/access/ConfirmedOwner.sol"; | |||
|
|
|||
| contract ScrollModule is ChainModuleBase, ConfirmedOwner { | |||
There was a problem hiding this comment.
We now have an owner of this chain module, we'll need to add appropriate steps in deployment and setup guide cc @anirudhwarrier
RyanRHall
reviewed
Aug 21, 2024
KuphJr
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
Resolves Dependencies