-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHIP-3003] ZKSync: Develop sequencer uptime feed contract #14250
[SHIP-3003] ZKSync: Develop sequencer uptime feed contract #14250
Conversation
…thub.com:smartcontractkit/chainlink into SHIP-3003/develop-sequencer-uptime-feed-contract-b
I see you updated files related to |
Static analysis results are availableHey @jlaveracll, you can view Slither reports in the job summary here or download them as artifact here. Please check them before merging and make sure you have addressed all issues. |
…thub.com:smartcontractkit/chainlink into SHIP-3003/develop-sequencer-uptime-feed-contract-b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also remove the surrounding empty comments
contracts/src/v0.8/l2ep/dev/zksync/ZKSyncSequencerUptimeFeed.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/l2ep/dev/zksync/ZKSyncSequencerUptimeFeed.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/l2ep/dev/zksync/ZKSyncSequencerUptimeFeed.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/l2ep/dev/zksync/ZKSyncSequencerUptimeFeed.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/l2ep/dev/zksync/ZKSyncSequencerUptimeFeed.sol
Outdated
Show resolved
Hide resolved
@jlaveracll once you have things in a stable spot, do you mind merging this PR with the other one here? It'd be great if we can consolidate all the feedback to one place 🙏 Also no need to have all the CI checks passing yet, we'll worry about this once things are all in one spot |
201c30b
into
SHIP-3004/develop-sequencer-uptime-feed-contract
Quality Gate passedIssues Measures |
Requires Dependencies
Resolves Dependencies