Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIP-3003] ZKSync: Develop sequencer uptime feed contract #14250

Conversation

jlaveracll
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

…thub.com:smartcontractkit/chainlink into SHIP-3003/develop-sequencer-uptime-feed-contract-b
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@jlaveracll jlaveracll changed the base branch from develop to SHIP-3004/develop-sequencer-uptime-feed-contract August 27, 2024 17:02
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Static analysis results are available

Hey @jlaveracll, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

…thub.com:smartcontractkit/chainlink into SHIP-3003/develop-sequencer-uptime-feed-contract-b
Copy link
Contributor

@chris-de-leon-cll chris-de-leon-cll Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Only have a few comments related to styling (for reference, let's try to follow the style guide here as much as possible.

One thing you'll want to do for this file and the Validator is replace all comments that look like this /** */ with this /// (see style guide here).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the surrounding empty comments

@chris-de-leon-cll
Copy link
Contributor

chris-de-leon-cll commented Aug 28, 2024

@jlaveracll once you have things in a stable spot, do you mind merging this PR with the other one here?

It'd be great if we can consolidate all the feedback to one place 🙏

Also no need to have all the CI checks passing yet, we'll worry about this once things are all in one spot

…thub.com:smartcontractkit/chainlink into SHIP-3003/develop-sequencer-uptime-feed-contract-b
@jlaveracll jlaveracll merged commit 201c30b into SHIP-3004/develop-sequencer-uptime-feed-contract Aug 29, 2024
73 of 78 checks passed
@jlaveracll jlaveracll deleted the SHIP-3003/develop-sequencer-uptime-feed-contract-b branch August 29, 2024 00:15
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants