Ccip-3463 multiclient in ccip tests #14581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix crib-integration-test workflow * run on changes to workflow file
…re (#14530) * set FinalityTagEnabled = true for testnets to match ccip config * Same changes on mainnets * Add changeset * generate config docs * Apply suggestions from code review Thanks for suggestions, I'll accept and replicate Co-authored-by: amit-momin <[email protected]> --------- Co-authored-by: amit-momin <[email protected]>
…ness (#14592) * Adding replay similar to other chain reader tests * Adding replay similar to other chain reader tests
* added configs * Tests & Docs
* fixed bug related to differences in cursor structure * Update core/chains/evm/logpoller/parser.go Co-authored-by: Jordan Krage <[email protected]> * reference new func --------- Co-authored-by: Jordan Krage <[email protected]>
* Update contract_reader.go and go.mod - Add rmn_remote package to contract_reader.go - Update chainlink-ccip version in go.mod * changeset * Use main branch commit * introducing logs * use most recent commit
* devsvcs-675: update debugging script to check max gas price * update * update
* Bump mcms, tools renamed to pkg * Mod tidy
* solana: add compute unit limit functionality * fix test: solana node CLI * fix: e2e test artifact upload to container * retry build with fresh commit * changeset * bump solana to merged commit
* CCIP 3388 - add commit store and RMN proxy state generation * update ARM to RMN
* [CAPPL-60] Use new EncoderFactory interface in ocr3 capability * Common bump * Add RMNRemote in the chain reader definition (#14588) * Update contract_reader.go and go.mod - Add rmn_remote package to contract_reader.go - Update chainlink-ccip version in go.mod * changeset * Use main branch commit * introducing logs * use most recent commit * solana: add compute unit limit functionality (#14576) * solana: add compute unit limit functionality * fix test: solana node CLI * fix: e2e test artifact upload to container * retry build with fresh commit * changeset * bump solana to merged commit * Common bump * go.mod bump --------- Co-authored-by: Cedric Cordenier <[email protected]> Co-authored-by: nogo <[email protected]> Co-authored-by: Aaron Lu <[email protected]> Co-authored-by: Silas Lenihan <[email protected]>
* Advanced Querying for ChainReader * Handle pointer type value comparator encoding * Handle geth abi panic when encoding data word value comparators * fix linting issues * [Bot] Update changeset file with jira issues * fix linting issues * [Bot] Update changeset file with jira issues * fix linting issues * [Bot] Update changeset file with jira issues * changed function name and added comments --------- Co-authored-by: ilija <[email protected]> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
* pass the home chain selector * Refactor contract reader configuration and add RMNHome contract support * Update chainlink-ccip dependency version * changeset * new chainlink-ccip version * bump chainlink-ccip * bump to main branch commit * using latest chainlink-ccip commit
…ion in rpc client (#14534) * polling subscription to be registered * adding changeset * fix Subscribe new head * add test * update changeset * fix lint * fix deadlock and add unit test for http polling sub * update changeset * adding sub closed check and remove import * add unit test coverage for http polling subscribeToHeads * update test * address comments part 1 * clean * part 2 * fix lint * fix lint
…14603) * Providing evm specific implementation of tokenDataEncoder * Providing evm specific implementation of tokenDataEncoder * go mod tidy * Post review fixes * Bump * Bump * Bump
AnieeG
force-pushed
the
ccip-3463-multiclient-tests
branch
from
f059fc3
to
85e1c07
Compare
* env changes * changes * lint * jd changes * fix typo --------- Co-authored-by: Connor Stein <[email protected]> updates change
AnieeG
force-pushed
the
ccip-3463-multiclient-tests
branch
from
85e1c07
to
6e024f8
Compare
AnieeG
commented
Oct 1, 2024
| var err error | ||
| receipt, err = client.TransactionReceipt(ctx, txHash) | ||
| return err | ||
| }) | ||
| }, ethereum.NotFound) |
There was a problem hiding this comment.
@connorwstein wdyt of this? I faced this during waiting for a transaction to get confirmed. Before it's confirmed it returns not found and back up logic tries to change the client. That's why added this to acceptable error so that it does not attempt to change client or retry unnecessarily if this error is encountered
ogtownsend
reviewed
Oct 1, 2024
| client, err := ethclient.Dial(rpc.WSURL) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to dial %s", rpc.WSURL) | ||
| lggr.Warnf("failed to dial rpc %d ending in %s, moving to next one", i+1, rpc.WSURL[len(rpc.WSURL)-4:]) |
There was a problem hiding this comment.
rpc.WSURL[len(rpc.WSURL)-4:]) could be just /ws/ for a lot of them, but I guess that's better than having to count RPCs in the TOML or exposing more of the URL. Another option is to load in "name" from the TOML and use rpc.Name
ogtownsend
reviewed
Oct 1, 2024
Comment on lines
164
to
167
| // If it is, log it and return nil | ||
| for _, acceptedError := range acceptedErrors { | ||
| if errors.Is(err, acceptedError) { | ||
| return err |
There was a problem hiding this comment.
// If it is, log it and return nil did you mean to return nil here?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses multiclient in smoke test
Updates to multiclient to have
KMSClient for setting deployer key
Adds CCIP config in chain state and view