Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE 2997 error building chainlink binary with wasmtime go dependency #14583

Merged
merged 57 commits into from
Oct 2, 2024
Merged

RE 2997 error building chainlink binary with wasmtime go dependency #14583

merged 57 commits into from
Oct 2, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Sep 27, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@HenryNguyen5 HenryNguyen5 force-pushed the RE-2997-error-building-chainlink-binary-with-wasmtime-go-dependency branch 2 times, most recently from cf16f3b to 4173c73 Compare September 27, 2024 23:06
@HenryNguyen5 HenryNguyen5 added the build-publish Build and Publish image to SDLC label Sep 28, 2024
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2997-error-building-chainlink-binary-with-wasmtime-go-dependency branch 2 times, most recently from c5603a9 to 5f68ca5 Compare October 1, 2024 17:09
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2997-error-building-chainlink-binary-with-wasmtime-go-dependency branch from dbfdf3f to 42f7c52 Compare October 1, 2024 19:16
chainchad
chainchad previously approved these changes Oct 1, 2024
View reviewed changes
@HenryNguyen5 HenryNguyen5 marked this pull request as ready for review October 1, 2024 20:11
@HenryNguyen5 HenryNguyen5 requested review from a team as code owners October 1, 2024 20:11
@HenryNguyen5 HenryNguyen5 requested review from vyzaldysanchez and removed request for a team October 1, 2024 20:11
@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue Oct 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 1, 2024
@HenryNguyen5
RE 2997 error building chainlink binary with wasmtime go dependency (#…
4cd0d2a 
…14583)

* Refactor .goreleaser.develop.yaml to use multi-platform native compilation

* Make required changes to get platform native builds working

* Programmatic goreleaser config generator, works with .goreleaser.develop.yaml

* Remove broken goreleaser makefile cmds

* Remove zig dep from shell.nix

* Remove macos-sdk, goreleaser exec, zig refs from goreleaser action

* Use no_unique_dist_dir config since we only build 1 target a time

* Remove qemu support

* Use ubuntu 24 for goreleaser base image

* Test split builds w/o merge

* Add sensible default for CHAINLINK_VERSION

* Set chainlink version in github action

* Merge ccip and regular builds together

* Use nightlies over snapshots

* Split and merge

* Correctly set release type

* Quote nullable var

* Pass down release type

* goreleaserpro -> goreleaser

* Set nightly version correctly

* Add fetch depth

* Make name more accurate

* Fix merge cmd

* Disable changelogs + archives unless prod

* Update develop config file

* Sign nightly images

* Handle prod image name prefix

* prod -> production

* Remove stale fixtures

* Add production config generation

* Correctly add ECR path to prod images

* Merge production + ccip production together

* Disable changelog on develop

* Remove env var shadowing and redundant templating

* Remove signing for develop builds

* Fix nightly version template

* Refactor build-sign-publish inputs

* Fix skippush condition, remove cosign signing

* Nuke cosign from goreleaser action in favor of gh artifact attestation

* Apply split+merge refactor to prod pipeline

* Run gomodtidy

* Remove useless test

* Update go.mod

* Remove push on release/** trigger

* Add fetch-depth 0 to image builds

* Use a separate workflow for goreleaser

* Update gomods

* TEST: goreleaser prod

* Add missing env

* Fix yaml extension

* Add missing fetch depth

* Fix incorrect manifest naming

* Configure skip_push for prod manifests

* Refactor artifact path handling in build-publish-goreleaser.yml

* Remove artifact attestation

* Update go.mod

* Remove test branch trigger
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@chainchad chainchad added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit 65f1d9d Oct 2, 2024
148 of 149 checks passed
@chainchad chainchad deleted the RE-2997-error-building-chainlink-binary-with-wasmtime-go-dependency branch October 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@erikburt erikburt erikburt approved these changes

@kalverra kalverra kalverra approved these changes

@timweri timweri timweri approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HenryNguyen5 @jmank88 @vyzaldysanchez @timweri @kalverra @erikburt @chainchad