Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling dynamic gas estimation for Hedera #14601

Merged
merged 9 commits into from
Oct 7, 2024
+54 −2
Merged

Enabling dynamic gas estimation for Hedera #14601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34a6a9a
turned on hedera gas estimation
simsonraj Sep 30, 2024
f6fdfbe
added hedera test overrides
simsonraj Sep 30, 2024
f50598c
enable dynamic gas Limit for Hedera
simsonraj Oct 1, 2024
f6c4406
Merge branch 'develop' into hedera_with_gas_estimation
simsonraj Oct 1, 2024
283fe46
Merge branch 'develop' into hedera_with_gas_estimation
simsonraj Oct 7, 2024
876b175
updated chainlink image
simsonraj Oct 7, 2024
90b3f9f
Merge branch 'hedera_with_gas_estimation' of https://github.com/smart…
simsonraj Oct 7, 2024
3861edd
Merge branch 'develop' into hedera_with_gas_estimation
simsonraj Oct 7, 2024
8f63ab1
Merge branch 'develop' into hedera_with_gas_estimation
simsonraj Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/chains/evm/config/toml/defaults/Hedera_Mainnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Mode = 'SuggestedPrice'
BumpThreshold = 0
BumpMin = '10 gwei'
BumpPercent = 20
# Dynamic gas estimation is a must Hedera, since Hedera consumes 80% of gaslimit by default, we will end up overpaying for gas
EstimateLimit = true

[Transactions]
# To hit throttling you'd need to maintain 15 m gas /sec over a prolonged period of time.
Expand Down
2 changes: 2 additions & 0 deletions core/chains/evm/config/toml/defaults/Hedera_Testnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Mode = 'SuggestedPrice'
BumpThreshold = 0
BumpMin = '10 gwei'
BumpPercent = 20
# Dynamic gas estimation is a must Hedera, since Hedera consumes 80% of gaslimit by default, we will end up overpaying for gas
EstimateLimit = true

[Transactions]
# To hit throttling you'd need to maintain 15 m gas /sec over a prolonged period of time.
Expand Down
4 changes: 2 additions & 2 deletions docs/CONFIG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4087,7 +4087,7 @@ LimitDefault = 500000
LimitMax = 500000
LimitMultiplier = '1'
LimitTransfer = 21000
EstimateLimit = false
EstimateLimit = true
BumpMin = '10 gwei'
BumpPercent = 20
BumpThreshold = 0
Expand Down Expand Up @@ -4191,7 +4191,7 @@ LimitDefault = 500000
LimitMax = 500000
LimitMultiplier = '1'
LimitTransfer = 21000
EstimateLimit = false
EstimateLimit = true
BumpMin = '10 gwei'
BumpPercent = 20
BumpThreshold = 0
Expand Down
48 changes: 48 additions & 0 deletions integration-tests/testconfig/ocr/overrides/hedera_testnet.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
[ChainlinkImage]
version = "283fe46b1d149c57ef2c70e6d5a1520dbc5b482e"

[Network]
selected_networks = ["HEDERA_TESTNET"]

[Soak.Common]
chainlink_node_funding = 30
number_of_contracts = 2

[Soak.OCR2]
[Soak.OCR2.Common]
test_duration = "240m"

[Soak.OCR2.Soak]
ocr_version = "2"
number_of_contracts = 2
time_between_rounds = "5m"

[Seth]
pending_nonce_protection_enabled = true

[Network.EVMNetworks.HEDERA_TESTNET]
evm_name = "HEDERA_TESTNET"
evm_chain_id = 296
client_implementation = "Ethereum"
evm_simulated = false
evm_chainlink_transaction_limit = 5000
evm_minimum_confirmations = 1
evm_gas_estimation_buffer = 100000
evm_supports_eip1559 = false
evm_default_gas_limit = 6000000

[[Seth.networks]]
name = "HEDERA_TESTNET"
transaction_timeout = "2m"
transfer_gas_fee = 800_000
gas_limit = 2_000_000
# legacy transactions
gas_price = 2_500_000_000_000
# EIP-1559 transactions
eip_1559_dynamic_fees = false
gas_fee_cap = 109_694_825_437
gas_tip_cap = 30_000_000_000
# if set to true we will estimate gas for every transaction
gas_price_estimation_enabled = false
# how many last blocks to use, when estimating gas for a transaction
gas_price_estimation_blocks = 0
Loading