Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Event Trigger Capability Development: Part 2 #14609

Merged
merged 9 commits into from
Oct 2, 2024

Conversation

kidambisrinivas
Copy link
Collaborator

@kidambisrinivas kidambisrinivas commented Sep 30, 2024

Updates

  • Receive log.Data as values.Value to preserve type info
  • Test cursor usage of LogEventTrigger capability to ensure that old logs are not sent as duplicates and only new logs are sent in the callback channel of registered Triggers
  • Add JSON schema for the capability config and output
  • Generate SDK helpers

References

SDK Generation

$ go generate ./core/capabilities/triggers/logevent/logeventcap

Testing

$ go test -count=1 -v -run="^TestLogEventTriggerEVMHappyPath$" ./core/services/relay/evm/capabilities
$ go test -count=1 -v -run="^TestLogEventTriggerCursorNewLogs$" ./core/services/relay/evm/capabilities

@kidambisrinivas kidambisrinivas requested a review from a team as a code owner September 30, 2024 22:30
@kidambisrinivas kidambisrinivas requested review from reductionista and removed request for a team September 30, 2024 22:30
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

go.mod Show resolved Hide resolved
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@kidambisrinivas kidambisrinivas added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit e724e5f Oct 2, 2024
127 of 128 checks passed
@kidambisrinivas kidambisrinivas deleted the CM-378-log-event-trigger-2 branch October 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants