Implement GetLatestValueWithHeadData contract reader method on ethereum

[ettec]

Implement GetLatestValueWithHeadData contract reader method on ethereum

depends on:
smartcontractkit/chainlink-common#898

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Find New Flaky Tests / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests / Run Tests , Find New Flaky Tests / Report , SonarQube Scan , Flakey Test Detection

1. Integer overflow conversion error: Golang Lint

Source of Error:

core/services/relay/evm/chain_reader.go:254:20: G115: integer overflow conversion int64 -> uint64 (gosec)
Timestamp: uint64(finalizedHead.Timestamp.Unix()),

Why: This error occurs because converting an int64 value to uint64 can result in an integer overflow if the int64 value is negative.

Suggested fix: Ensure that the int64 value is non-negative before converting it to uint64. Alternatively, handle the conversion safely by checking the value's range.

2. Incorrect nolint directive format: Golang Lint

Source of Error:

core/services/relay/evm/chain_reader.go:253:3: directive `//nolint:G115 Timestamp is always positive` should match `//nolint[:<comma-separated-linters>] [// <explanation>]` (nolintlint)

Why: The nolint directive format is incorrect. It should follow the pattern //nolint[:<comma-separated-linters>] [// <explanation>].

Suggested fix: Correct the nolint directive to match the required format, e.g., //nolint:gosec // Timestamp is always positive.

3. Unclean state after generate: Ensure clean after generate

Source of Error:

git diff --stat --exit-code
.../logeventcap/trigger_builders_generated.go | 74 +++++++++++++-------
.../webapi/webapicap/trigger_builders_generated.go | 78 ++++++++++++++--------
2 files changed, 100 insertions(+), 52 deletions(-)

Why: The generated files have changes that were not committed, indicating that the code generation step modified files but did not result in a clean state.

Suggested fix: Ensure that all generated files are up-to-date and committed before running the git diff check. Run the code generation step and commit any changes.

4. Test failure due to unexpected nil error: Core Tests (go_core_tests)

Source of Error:

Error: An error is expected but got nil.
Test: TestChainComponents/GetLatestValueWithHeadData_for_EVM_on_loop/Get_latest_value_based_on_confidence_level_for_EVM_on_loop

Why: The test expected an error but received nil, indicating that the function did not behave as expected under test conditions.

Suggested fix: Review the test case and the function under test to ensure that the expected error conditions are correctly simulated and handled.

5. Test failure due to context deadline exceeded: Core Tests (go_core_tests)

Source of Error:

Error: Received unexpected error: failed to get transaction status: failed to find transaction with IdempotencyKey e12f68e3-7db9-41d1-b981-b9ef8e2df948: FindTxWithIdempotencyKey failed to load evm.txes: context deadline exceeded
Test: TestChainComponents/QueryKey_for_EVM_on_loop/QueryKey_can_filter_data_with_value_comparator_for_EVM_on_loop

Why: The test encountered a timeout while waiting for a transaction status, indicating that the operation took longer than the allowed time.

Suggested fix: Increase the context timeout for the test or optimize the function to complete within the expected time frame.

6. Test failure due to RPC deadline exceeded: Core Tests (go_core_tests)

Source of Error:

Error: Received unexpected error: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Test: TestChainComponents/QueryKey_for_EVM_on_loop/QueryKey_can_limit_results_with_cursor_for_EVM_on_loop

Why: The test encountered an RPC timeout, indicating that the remote procedure call took longer than the allowed time.

Suggested fix: Increase the RPC timeout for the test or optimize the RPC call to complete within the expected time frame.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[ilija42]

This won't give you a guarantee that the attached block is the same block that the data was read from. You'll have to return the same block height calculated in EventBinding or MethodBinding

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.