-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding otel attributes to config_telemetry #15084
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CIaer_workflow , commit , Breaking Changes GQL Check 1. Workflow failed to complete successfully:[Breaking Changes GQL Check]Source of Error:
Why: The triggered workflow did not complete successfully, resulting in a failure status. This failure was then propagated back to the upstream job, causing the entire run to fail. Suggested fix: Investigate the logs of the downstream workflow (ID: 11747552668) to identify the specific cause of the failure and address the underlying issue. |
9afb641
to
d055da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NONEVM-828
I considered 3 options while implementing this:
static.Version
field is set at build time, so its available to tests that test default TOML. From a user experience though, I may want to always set these fields, so user configurable does not seem like a perfect fit.beholder.Config
. Most straightforward to read and reason about, but either introduces duplication when loops are spun up or pollutes a clean default initialization of a beholder client.Requires
Supports