Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding otel attributes to config_telemetry #15084

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Nov 2, 2024

NONEVM-828

I considered 3 options while implementing this:

  1. Make these fields defaults in the TOML. The static.Version field is set at build time, so its available to tests that test default TOML. From a user experience though, I may want to always set these fields, so user configurable does not seem like a perfect fit.
  2. The current approach, which overrides the getter on ResourceAttributes after the general app config has been made
  3. Set these values way higher in the stack for the consumers of beholder.Config. Most straightforward to read and reason about, but either introduces duplication when loops are spun up or pollutes a clean default initialization of a beholder client.

Requires

Supports

Copy link
Contributor

github-actions bot commented Nov 2, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI

aer_workflow , commit , Breaking Changes GQL Check

1. Workflow failed to complete successfully:[Breaking Changes GQL Check]

Source of Error:
Run convictional/trigger-workflow-and-wwait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-08T18:29:01.7269656Z Checking conclusion [failure]
Run convictional/trigger-workflow-and-wwait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-08T18:29:01.7270734Z Checking status [completed]
Run convictional/trigger-workflow-and-wwait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-08T18:29:01.7272187Z Conclusion is not success, it's [failure].
Run convictional/trigger-workflow-and-wwait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-08T18:29:01.7273585Z Propagating failure to upstream job

Why: The triggered workflow did not complete successfully, resulting in a failure status. This failure was then propagated back to the upstream job, causing the entire run to fail.

Suggested fix: Investigate the logs of the downstream workflow (ID: 11747552668) to identify the specific cause of the failure and address the underlying issue.

Atrax1
Atrax1 previously approved these changes Nov 4, 2024
Copy link
Contributor

@Atrax1 Atrax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krehermann
krehermann previously approved these changes Nov 8, 2024
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit c759978 Nov 8, 2024
136 of 139 checks passed
@patrickhuie19 patrickhuie19 deleted the chore/NONEVM-828 branch November 8, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants