Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keystone] Launcher: don't fail if some capabilities are missing locally #15174

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[Keystone] Launcher: don't fail if some capabilities are missing locally #15174

merged 1 commit into from
Nov 11, 2024
+37 −27

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Nov 8, 2024

If the onchain registry has capabilities that are not enabled locally, we don't want to fail everything but continue launching other capabilities that are available.

@bolekk
[Keystone] Launcher: don't fail if some capabilities are missing locally
1fa5efe 
If the onchain registry has capabilities that are not enabled locally, we don't
want to fail everything but continue launching other capabilities that are available.
@bolekk bolekk requested review from a team as code owners November 8, 2024 23:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

bolekk
bolekk commented Nov 8, 2024
View reviewed changes
core/services/registrysyncer/syncer.go
@@ -202,7 +202,7 @@ func (s *registrySyncer) updateStateLoop() {
}
}

func (s *registrySyncer) localRegistry(ctx context.Context) (*LocalRegistry, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name was really confusing.

@bolekk bolekk requested a review from archseer November 9, 2024 16:00
@bolekk bolekk enabled auto-merge November 9, 2024 16:00
@bolekk bolekk added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 9ac601d Nov 11, 2024
138 of 139 checks passed
@bolekk bolekk deleted the bugfix/launcher-missing-caps branch November 11, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@krehermann krehermann krehermann approved these changes

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolekk @krehermann @cedric-cordenier