Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Foundry Guide and update Solidity Style Guide #15199

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Nov 12, 2024

No description provided.

@RensR RensR requested a review from a team as a code owner November 12, 2024 13:46
contracts/FOUNDRY_GUIDE.md Show resolved Hide resolved
contracts/STYLE_GUIDE.md Outdated Show resolved Hide resolved
@matYang
Copy link
Contributor

matYang commented Nov 13, 2024

nice foundry starter guide =)

Copy link
Contributor

github-actions bot commented Nov 13, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

test_FunctionName_Description for standard tests.
test_FunctionName_RevertWhen_Condition for tests expecting a revert.
testFuzz_FunctionName_Description for fuzz tests.
testFork_FunctionName_Description for tests that fork from a network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldn't be test_functionName_Description?

@RensR RensR added this pull request to the merge queue Nov 18, 2024
Merged via the queue into develop with commit d7d1750 Nov 18, 2024
89 of 90 checks passed
@RensR RensR deleted the CCIP-4192-write-foundry-guide branch November 18, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants