Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "core/internal/features/ocr2: parallelize subtests..." #15792

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Dec 20, 2024

Reverts changes from #14754 / ec35d77.

Motivation

We've been seeing a lot of failures from http://github.com/smartcontractkit/chainlink/v2/core/internal/features/ocr2/plugins. This change may have caused some instability with the go-conditional-tests.

More information: https://smartcontract-it.atlassian.net/browse/RE-3313?focusedCommentId=338207

Testing

I tested partial reverts of these changes: #15795

The full revert was the most consistent - https://github.com/smartcontractkit/chainlink/actions/runs/12435970239/job/34727487863?pr=15792


RE-3313

@erikburt erikburt self-assigned this Dec 20, 2024
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@erikburt erikburt marked this pull request as ready for review December 20, 2024 19:58
@erikburt erikburt requested review from a team as code owners December 20, 2024 19:58
@erikburt erikburt requested a review from jmank88 December 20, 2024 19:58
@erikburt erikburt enabled auto-merge December 20, 2024 20:01
@erikburt erikburt added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@erikburt erikburt added this pull request to the merge queue Dec 20, 2024
@erikburt erikburt removed this pull request from the merge queue due to a manual request Dec 20, 2024
@erikburt erikburt added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@erikburt erikburt added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 7314c07 Dec 20, 2024
168 of 169 checks passed
@erikburt erikburt deleted the chore/revert-internal-features-ocr2-test-par branch December 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants