CCIP Config backported from CCIP repo #15856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
force-pushed
the
ccip-config
branch
from
e17e73f to
d2b9ee7
Compare
mateusz-sekara
changed the base branch from
etb/toml-custom-fallback
to
develop
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
mateusz-sekara
force-pushed
the
ccip-config
branch
from
d2b9ee7 to
9d86538
Compare
|
simsonraj
approved these changes
Jan 8, 2025
dhaidashenko
reviewed
Jan 8, 2025
| @@ -18,4 +18,6 @@ PriceDefault = '1 gwei' | |||
| BlockHistorySize = 24 | |||
|
|
|||
| [HeadTracker] | |||
| PersistenceEnabled = false | |||
There was a problem hiding this comment.
PersistenceEnabled = false allows HeadTracker to stop persisting heads. This operation generates a significant load on the database, but it does not provide any benefits on chains with fast finality.
We should not remove the override of the flag.
There was a problem hiding this comment.
Hmm, this is interesting. I've just backported the state from the CCIP repo. Exactly how it is right now on the develop branch
There was a problem hiding this comment.
It was reverted here smartcontractkit/ccip@c279cbb
| @@ -1,5 +1,5 @@ | |||
| ChainID = '59141' | |||
| FinalityDepth = 900 | |||
There was a problem hiding this comment.
Is it ok, that we are reducing finality depth?
dhaidashenko
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Agreed with @simsonraj that comments can be addressed in a followup PRs as ccip config changes present in develop branch were not actually tested and our main goal with this PR is to sync ccip and core repos
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
asoliman92
pushed a commit
that referenced
this pull request
Jan 9, 2025
* Moving configs directly from CCIP repo * Moving configs directly from CCIP repo
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
…15605) * replace f with fObserve in RMHome and RMNRemote * Update gethwrappers * rename fObserve to fSign * fix off-chain components of renaming RMN parameters * core changeset * update missing file for new parameter name * fix wrappers * fix merge conflict broken text * Update gethwrappers * attempt fix json export tag * Update gethwrappers * upgrade cl-ccip and fix test * upgrade cl-ccip@main * upgrade cl-ccip@main * fix test * upgrade cl-ccip@main * Update gethwrappers * upgrade chainlink ccip * DEVSVCS-1087: remove unused automation hardhat tests (#15847) * remove unused automation hardhat tests * freeze contracts * remove more tests * update * CCIP Config backported from CCIP repo (#15856) * Moving configs directly from CCIP repo * Moving configs directly from CCIP repo * Remove panic recovery for wsrpc (#15865) - Due to some other bug in the library, the redialled connection never becomes ready. * Added is_backfiled filed to solana's filter table (#15796) * Extract MultiNode to chainlink-framework (#15791) * Extract MultiNode * tidy * tidy * Fix generate * Add mock Subscription * lint * Fix sendonly allocation * lint * Add QueryTimeout to client * Use multinode * Update rpc_client_test.go * improve peer group dialer sync function logs (#15867) * Solana devnet spin up in memory env (A) (#15831) * Adding solchains in NewEnv * Revert "Adding solchains in NewEnv" This reverts commit aaab52e. * adding sol chains to newenv * newEnv needs to send nil * adding test env setup * adding nil for crib sol chains * adding chain selectors commit * go mod tidy * linting * chain sel update * update core/scripts go files * again * add changeset * go imports * go mod tidy * Update modgraph --------- Co-authored-by: Terry Tata <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]> * upgrade chainlink ccip fixing router binding issues in migration * upgrade chainlink ccip fixing router binding issues in migration * fix comment * gomodtidy and formatting fix * update go mod file for newest cl-ccip * update comment --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Simon B.Robert <[email protected]> Co-authored-by: dimkouv <[email protected]> Co-authored-by: asoliman <[email protected]> Co-authored-by: FelixFan1992 <[email protected]> Co-authored-by: Mateusz Sekara <[email protected]> Co-authored-by: Sam <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]> Co-authored-by: Dylan Tinianov <[email protected]> Co-authored-by: Yashvardhan Nevatia <[email protected]> Co-authored-by: Terry Tata <[email protected]> Co-authored-by: Blaž Hrastnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
#15617
Based on the state from ccip ea7c200
smartcontractkit/ccip@ea7c200
Supports