add chains to ccip in crib setup #15862
Open
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustinWang
changed the title
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
reviewed
Jan 8, 2025
AnieeG
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Is it possible to put crib env set up implementing TestEnvironment interface? It will take care all the set up for you out of the box if you just call - NewEnvironmentWithJobsAndContracts
AnieeG
reviewed
Jan 8, 2025
AnieeG
previously approved these changes
Jan 9, 2025
|
|
Discussed with @AnieeG offline, but we can't use the TestEnvironment interface due to its dependence on |
makramkd
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add chains in crib setup before we can add lanes