Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destexecdata decoder support + refactor #15978

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

huangzhen1997
Copy link
Contributor

@huangzhen1997 huangzhen1997 commented Jan 17, 2025

Step 2 for https://smartcontract-it.atlassian.net/browse/NONEVM-1163. This PR implements a new function added for plugin oracle creator extradata codec based on smartcontractkit/chainlink-ccip#472. This PR is just an noop, the actual implementation will be submitted with a different PR and gets merged into solana-offchain-plugin branch, where we need to process the bytes base on the source chain and reassign the bytes to message.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Clean Go Tidy & Generate , Detect Changes , GolangCI Lint (core/scripts) , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , GolangCI Lint (integration-tests/load) , Core Tests (go_core_tests_integration) , GolangCI Lint (integration-tests) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (deployment) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. GolangCI Lint failed to load package actions: [Golang Lint (integration-tests/load)]

Source of Error:
Golang Lint (integration-tests/load) 2025-01-23T21:38:02.1429426Z level=error msg="Running error: can't run linter goanalysis_metalinter\ninspect: failed to load package actions: could not load export data: no export data for \"github.com/smartcontractkit/chainlink/integration-tests/actions\""

Why: The linter failed because it couldn't load the export data for the specified package. This usually happens when the package is missing or there are issues with the module dependencies.

Suggested fix: Ensure that the github.com/smartcontractkit/chainlink/integration-tests/actions package exists and is correctly referenced in the go.mod file. Run go mod tidy to clean up any issues with module dependencies.

2. No such file or directory: [Golang Lint (integration-tests/load)]

Source of Error:
Golang Lint (integration-tests/load) 2025-01-23T21:38:02.1654071Z cat: ./integration-tests/load/golangci-lint-report.xml: No such file or directory

Why: The linter report file golangci-lint-report.xml was not generated, likely due to the previous error in running the linter.

Suggested fix: Fix the underlying issue causing the linter to fail (see previous error). Once the linter runs successfully, the report file should be generated.

3. Declared and not used: [Golang Lint (integration-tests)]

Source of Error:
Golang Lint (integration-tests) 2025-01-23T21:38:03.8293038Z ##[error]integration-tests/smoke/ccip/ccip_usdc_test.go:54:2: declared and not used: ownerChainB (typecheck)
Golang Lint (integration-tests) 2025-01-23T21:38:03.8294064Z 	ownerChainB := e.Chains[chainB].DeployerKey
Golang Lint (integration-tests) 2025-01-23T21:38:03.8294505Z 	^

Why: The variable ownerChainB is declared but not used in the code, which is flagged by the linter as an error.

Suggested fix: Either use the ownerChainB variable in the code or remove its declaration if it is not needed.

4. Process completed with exit code 1: [Ensure clean after tidy]

Source of Error:
Ensure clean after tidy 2025-01-23T21:44:46.4423751Z ##[error]Process completed with exit code 1.

Why: The git diff --cached --exit-code command found differences after running go mod tidy, indicating that the repository is not clean.

Suggested fix: Commit the changes made by go mod tidy to ensure the repository is clean. This can be done by running git add . and git commit -m "Clean up after go mod tidy" before running the action.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant