Simplify testhelpers to make it easier to support non-EVM #16040
Conversation
archseer
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
archseer
force-pushed
the
testhelpers-simplify
branch
3 times, most recently
from
5ba0a78 to
c489d1d
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
archseer
force-pushed
the
testhelpers-simplify
branch
from
c489d1d to
57bba15
Compare
| srcSelector uint64, | ||
| dest deployment.Chain, |
There was a problem hiding this comment.
nit: it will be easier to switch to same type of input parameter for src and dest both. If you are using selector for source, does it make sense to change the same for dest too?
There was a problem hiding this comment.
Yeah I'm working towards that, I think all of these base methods will probably end up being a interface that deployment.Chain and deployment.SolChain (or a wrapper) implement. That way we have a couple building blocks that are chain agnostic (send request, send token, transfer tokens, wait for events/commit/exec)
Wanted to get rid of the source chain first so that the logic only depends on the destination, that way we only need two versions of the code (evm, solana rather than evm->solana, solana->evm, evm->evm and solana->solana)
archseer
force-pushed
the
testhelpers-simplify
branch
from
57bba15 to
dd110e2
Compare
…mit in helpers All smoke tests assume blocks are being produced
This is now doable since we no longer call source.backend.Commit()
archseer
force-pushed
the
testhelpers-simplify
branch
from
dd110e2 to
f3385ff
Compare
|
MineBlocksif they expect blocks to be produced regularly