bump cosmos-sdk; remove cometbft #16639
Merged
+989
−980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
samsondav
previously approved these changes
Feb 28, 2025
Atrax1
previously approved these changes
Feb 28, 2025
Atrax1
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Noticed this error
Error: ../../../../go/pkg/mod/github.com/cometbft/[email protected]/crypto/secp256k1/secp256k1.go:132:9: assignment mismatch: 1 variable but ecdsa.SignCompact returns 2 values
on the unit tests
jmank88
force-pushed
the
bump-cosmos-sdk-rm-cometbft
branch
from
b0983e0 to
12306e5
Compare
jmank88
commented
Feb 28, 2025
Comment on lines
382
to
383
| // replicating the replace directive on cosmos SDK | ||
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 |
There was a problem hiding this comment.
We are stuck with this for some reason. Cosmos and geth both use github.com/gogo/protobuf v1.3.2, without any replace, but something else is trying to force us to v1.3.3 still... 🤔
samsondav
previously approved these changes
Feb 28, 2025
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
pavel-raykov
approved these changes
Feb 28, 2025
pavel-raykov
approved these changes
Feb 28, 2025
samsondav
approved these changes
Feb 28, 2025
Atrax1
approved these changes
Feb 28, 2025
eutopian
approved these changes
Feb 28, 2025
RensR
approved these changes
Feb 28, 2025
krehermann
approved these changes
Feb 28, 2025
krehermann
approved these changes
Feb 28, 2025
jmank88
requested review from
dav009,
alecgard,
scalabilitysolved,
cawthorne,
mjk90,
Subarna-Singh,
karen-stepanyan,
mmcallister-cll and
mxiao-cll
FelixFan1992
approved these changes
Mar 1, 2025
alecgard
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the chainlink-cosmos dep removed, we are unblocked from bumping
cosmos-sdkwhich is only used by the keystore.cometbftwas only used for random integers and a strings package, both of which can be swapped over to the standard library.