fix(core-tests): wait for SyncNodeInfo calls in fms tests #16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
gustavogama-cll
force-pushed
the
ggama/fix-core-tests-wait-syncnodeinfo-fms-tests
branch
from
631bf95 to
db140ad
Compare
|
gustavogama-cll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving the "SyncNodeInfo" calls to a goroutine, some unit tests could fail sporadically because the mocking library expects the fms client calls to be executed along with the database calls. This PR fixes this by ensuring we wait for the "SyncNodeInfo" calls before ending the test and running the mock assertions.