Skip to content

DF-21310: Add coinmetrics-lwba adapter #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

DF-21310: Add coinmetrics-lwba adapter #3854

wants to merge 8 commits into from

Conversation

florian-cl
Copy link

@florian-cl florian-cl commented May 12, 2025

Closes #DF-21310

Description

For cost savings, structuring team wants us to create a coinmetrics-lwba EA, that only offers lwba endpoint capabilities and offers endpoint = crypto or price instead of endpoint = crypto-lwba

Changes

  • High level
  • changes that
  • you made

Steps to Test

  1. Steps
  2. to
  3. test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: ccaa3fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/coinmetrics-lwba-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxiao-cll
Copy link
Contributor

Is this a complete copy of the existing endpoint?

  1. I don't quite understand why this is necessary, raised a comment in the ticket
  2. If this is needed, we should instead of copy code, let this EA depend on the old EA and reference the core logic directly

): string => {
const { API_KEY, WS_API_ENDPOINT } = context.adapterSettings

const generated = new URL('/v4/timeseries-stream/asset-quotes', WS_API_ENDPOINT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should /v4/timeseries-stream/asset-quotes be part of WS_API_ENDPOINT?

type: 'string',
default: 'wss://api.coinmetrics.io/v4',
},
API_ENDPOINT: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants