Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPA-1321]: fix(chainconfig): attach label to key bundle id #96

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

graham-chainlink
Copy link
Collaborator

For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321

Testing

Screenshot 2024-11-20 at 3 37 57 pm Screenshot 2024-11-20 at 3 38 01 pm

For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.9% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@archseer archseer merged commit da96bcb into main Nov 20, 2024
6 of 7 checks passed
@archseer archseer deleted the ggoh/DPA-1321/chain-config-bundle-id-label branch November 20, 2024 07:52
graham-chainlink added a commit to smartcontractkit/chainlink that referenced this pull request Nov 20, 2024
For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

Context: smartcontractkit/operator-ui#96

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321
github-merge-queue bot pushed a commit to smartcontractkit/chainlink that referenced this pull request Nov 20, 2024
For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

Context: smartcontractkit/operator-ui#96

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321
github-merge-queue bot pushed a commit to smartcontractkit/chainlink that referenced this pull request Nov 20, 2024
For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

Context: smartcontractkit/operator-ui#96

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321
github-merge-queue bot pushed a commit to smartcontractkit/chainlink that referenced this pull request Nov 20, 2024
For the ocr2 keybundle id select box, it lists all the keys based on the ID and it's hard to tell which one we want. Adding the key type (aptos, evm etc) to the values in the selectbox, something like "0xaaabbbccc (aptos)" so it can be easily identified now that we support more than EVM chain.

Context: smartcontractkit/operator-ui#96

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants