Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libocr; add context #37

Merged
merged 1 commit into from
Oct 9, 2024
Merged

bump libocr; add context #37

merged 1 commit into from
Oct 9, 2024

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Apr 25, 2024 •
edited
Loading

This was referenced Apr 25, 2024
Closed
Draft
Merged
This was referenced Jul 30, 2024
Draft
Merged
Merged
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch 2 times, most recently from b81c0f1 to 49cd7d1 Compare August 5, 2024 12:47
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch 2 times, most recently from ab7ffac to 58d74cd Compare September 17, 2024 22:10
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 3aa0311 to 16e01de Compare October 7, 2024 23:50
@jmank88 jmank88 mentioned this pull request Oct 8, 2024
Merged
@jmank88 jmank88 marked this pull request as ready for review October 8, 2024 15:00
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch 2 times, most recently from 376e6a5 to e356c54 Compare October 8, 2024 15:02
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from e356c54 to 2947336 Compare October 8, 2024 15:05
@coventry
Copy link
Collaborator

coventry commented Oct 8, 2024

Why is there such a large increase in the go.work.sum file?

coventry
coventry reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@coventry coventry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve this PR, if we can identify the source of the increased dependencies in the sum file.

@jmank88
Copy link
Collaborator Author

jmank88 commented Oct 8, 2024 •
edited
Loading

I think the go.work.sum is just growing from working in a local workspace and no tidy command to clean it up - but it has no effect on the build since these are just checksums for reference.

coventry
coventry approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@coventry coventry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, SGTM.

@pszal pszal merged commit 33d0c0b into main Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coventry coventry coventry approved these changes

@stchrysa stchrysa Awaiting requested review from stchrysa

@bolekk bolekk Awaiting requested review from bolekk

@pszal pszal Awaiting requested review from pszal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @coventry @pszal