REL-1526 - Fix context propagation for async communication #1
Conversation
kamsobon
force-pushed
the
fixContextPropagation
branch
from
5a44aaa to
5f7a37f
Compare
Previous fix was handling cases when trace context was restored from event on consumer side. Due to unknown reasons this code that was manipulating message headers was invoked (https://github .com/opentracing-contrib/java-rabbitmq-client/blob/master/src/main/java /io/opentracing/contrib/rabbitmq/TracingUtils.java#L67-L74). Unfortunately, this fix was breaking injecting tracing context on producer side, which effectively was killing context propagation.
kamsobon
force-pushed
the
fixContextPropagation
branch
from
5f7a37f to
5d17586
Compare
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| @@ -1,54 +1,36 @@ | |||
| [![Build Status][ci-img]][ci] [![Coverage Status][cov-img]][cov] [![Released Version][maven-img]][maven] [](https://opensource.org/licenses/Apache-2.0) | |||
| # Purpose | |||
There was a problem hiding this comment.
Codacy found an issue: [final-newline] Missing newline character at end of file
| [maven-img]: https://img.shields.io/maven-central/v/io.opentracing.contrib/opentracing-rabbitmq-client.svg | ||
| [maven]: http://search.maven.org/#search%7Cga%7C1%7Copentracing-rabbitmq-client | ||
| 4. Run `mvn clean install` | ||
| 5. Run `mvn source:jar deploy` |
There was a problem hiding this comment.
Codacy found an issue: Expected: 2; Actual: 5; Style: 1/2/3
| [cov]: https://coveralls.io/github/opentracing-contrib/java-rabbitmq-client?branch=master | ||
| [maven-img]: https://img.shields.io/maven-central/v/io.opentracing.contrib/opentracing-rabbitmq-client.svg | ||
| [maven]: http://search.maven.org/#search%7Cga%7C1%7Copentracing-rabbitmq-client | ||
| 4. Run `mvn clean install` |
There was a problem hiding this comment.
Codacy has a fix for the issue: Lists should be surrounded by blank lines
| 4. Run `mvn clean install` | |
| 4. Run `mvn clean install` |
| # Publishing changes | ||
| 1. Adjust version in `pom.xml` | ||
| 2. Replace `{SR Nexus URL}` in `pom.xml` with URL to nexus | ||
| 3. Create settings for maven in `~/.m2/settings.xml |
There was a problem hiding this comment.
Codacy has a fix for the issue: Lists should be surrounded by blank lines
| 3. Create settings for maven in `~/.m2/settings.xml | |
| 3. Create settings for maven in `~/.m2/settings.xml | |
| [maven-img]: https://img.shields.io/maven-central/v/io.opentracing.contrib/opentracing-rabbitmq-client.svg | ||
| [maven]: http://search.maven.org/#search%7Cga%7C1%7Copentracing-rabbitmq-client | ||
| 4. Run `mvn clean install` | ||
| 5. Run `mvn source:jar deploy` |
There was a problem hiding this comment.
Codacy found an issue: [list-item-indent] Incorrect list-item indent: add 1 space
|
|
||
| pom.xml | ||
| # Publishing changes | ||
| 1. Adjust version in `pom.xml` |
There was a problem hiding this comment.
Codacy has a fix for the issue: Lists should be surrounded by blank lines
| 1. Adjust version in `pom.xml` | |
| 1. Adjust version in `pom.xml` |
| ## Installation | ||
|
|
||
| pom.xml | ||
| # Publishing changes |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected: 1; Actual: 0; Below
| # Publishing changes | |
| # Publishing changes | |
| # Publishing changes | ||
| 1. Adjust version in `pom.xml` | ||
| 2. Replace `{SR Nexus URL}` in `pom.xml` with URL to nexus | ||
| 3. Create settings for maven in `~/.m2/settings.xml |
There was a problem hiding this comment.
Codacy found an issue: [list-item-indent] Incorrect list-item indent: add 1 space
|
|
||
| pom.xml | ||
| # Publishing changes | ||
| 1. Adjust version in `pom.xml` |
There was a problem hiding this comment.
Codacy found an issue: [list-item-indent] Incorrect list-item indent: add 1 space
| [cov]: https://coveralls.io/github/opentracing-contrib/java-rabbitmq-client?branch=master | ||
| [maven-img]: https://img.shields.io/maven-central/v/io.opentracing.contrib/opentracing-rabbitmq-client.svg | ||
| [maven]: http://search.maven.org/#search%7Cga%7C1%7Copentracing-rabbitmq-client | ||
| 4. Run `mvn clean install` |
There was a problem hiding this comment.
Codacy found an issue: [list-item-indent] Incorrect list-item indent: add 1 space
| pom.xml | ||
| # Publishing changes | ||
| 1. Adjust version in `pom.xml` | ||
| 2. Replace `{SR Nexus URL}` in `pom.xml` with URL to nexus |
There was a problem hiding this comment.
Codacy found an issue: [list-item-indent] Incorrect list-item indent: add 1 space
| ## Installation | ||
|
|
||
| pom.xml | ||
| # Publishing changes |
There was a problem hiding this comment.
Codacy found an issue: Multiple top-level headings in the same document
| [cov]: https://coveralls.io/github/opentracing-contrib/java-rabbitmq-client?branch=master | ||
| [maven-img]: https://img.shields.io/maven-central/v/io.opentracing.contrib/opentracing-rabbitmq-client.svg | ||
| [maven]: http://search.maven.org/#search%7Cga%7C1%7Copentracing-rabbitmq-client | ||
| 4. Run `mvn clean install` |
There was a problem hiding this comment.
Codacy found an issue: Expected: 1; Actual: 4; Style: 1/2/3
| @@ -1,54 +1,36 @@ | |||
| [![Build Status][ci-img]][ci] [![Coverage Status][cov-img]][cov] [![Released Version][maven-img]][maven] [](https://opensource.org/licenses/Apache-2.0) | |||
| # Purpose | |||
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected: 1; Actual: 0; Below
| # Purpose | |
| # Purpose | |
Previous fix was handling cases when trace context was restored from
event on consumer side. Due to unknown reasons this code that was
manipulating message headers was invoked (https://github
.com/opentracing-contrib/java-rabbitmq-client/blob/master/src/main/java
/io/opentracing/contrib/rabbitmq/TracingUtils.java#L67-L74).
Unfortunately, this fix was breaking injecting tracing context on
producer side, which effectively was killing context propagation.