Add "Put" Actuator Data to turn on/off LED #3
Conversation
PUT Actuator Data to turn on/off LED patch 2
Updates to the patch
TO DO - Change error 404 response in every if conditions in handler and return buffzie resp_len (based on pull request on rosetree)
There was a problem hiding this comment.
Thanks @seojeongmoon for addressing this!
I leave some comments about this pull request. But more general: Could you update your code to meet the RIOT coding conventions? Like the usage of spaces, indentation and stuff.
Also I don’t really know, how I am supposed to use this feature. Can you explain the usage in a new section of README.md? How should the resource be called? What data should be submitted?
|
|
||
| /* CoAP resources. Must be sorted by path (ASCII order). */ | ||
| static const coap_resource_t _resources[] = { | ||
| { "/hum", COAP_GET, _sense_hum_handler, NULL }, | ||
| { "/press", COAP_GET, _sense_press_handler, NULL }, | ||
| { "/saul/cnt", COAP_GET, _saul_cnt_handler, NULL }, | ||
| { "/saul/dev", COAP_POST, _saul_dev_handler, NULL }, | ||
| {"/saul/atr", COAP_PUT, _saul_atr_handler, NULL}, |
There was a problem hiding this comment.
What does atr stand for? Attribute? Another coding style related request: could you use a space after { and before }, like in the surrounding lines.
| @@ -38,10 +38,21 @@ The idea of these resources is, to offer similar functionality as the | |||
|
|
|||
|
|
|||
| ## Build and Execute | |||
|
|
|||
| Directory: X/riot-saul-coap/RIOT/examples/gcoap/ | |||
There was a problem hiding this comment.
Could you add a small statement when this directory should be used? We only need it for the GET requests, but still have to run the make command in the project directory. Also you could change X/riot-saul-coap to . (which would mean: in this project directory).
|
|
||
| coap get <ip address> 5683 <resource> | ||
|
|
||
| With DTLS, port number is 5684 |
There was a problem hiding this comment.
Good idea to include the different port! Thanks :)
| @@ -13,7 +13,8 @@ | |||
| * @file | |||
| * @brief CoAP endpoint for the SAUL registry | |||
| * | |||
| * @author Micha Rosenbaum <[email protected]> | |||
| * @author Seojeong Moon <[email protected]> | |||
| @author Micha Rosenbaum <[email protected]> | |||
There was a problem hiding this comment.
Thank you, that you included yourself. I should have done this earlier.
Could need some code style improvements, like the * at the beginning and the spaces between the @author tag and the name.
saul_coap.c
Outdated
| @@ -24,30 +25,41 @@ | |||
| #include "saul_reg.h" | |||
| #include "fmt.h" | |||
| #include "net/gcoap.h" | |||
| #include "cbor.h" | |||
| #include "phydat.h" | |||
| //#include "winch.h" | |||
There was a problem hiding this comment.
What’s that? Work in progress?
| @@ -0,0 +1,78 @@ | |||
|
|
|||
There was a problem hiding this comment.
Should this file be merged?
update RIOT submodule to include DTLS patches
No description provided.