Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CAPI to v1.5.1 #145

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Bump CAPI to v1.5.1 #145

merged 2 commits into from
Sep 25, 2023

Conversation

haijianyang
Copy link
Contributor

@haijianyang haijianyang commented Sep 13, 2023 •
edited by jessehu
Loading

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #145 (61486e1) into master (7253a00) will increase coverage by 0.14%.
Report is 1 commits behind head on master.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   55.83%   55.97%   +0.14%     
==========================================
  Files          16       16              
  Lines        2735     2744       +9     
==========================================
+ Hits         1527     1536       +9     
  Misses       1073     1073              
  Partials      135      135
Files Changed Coverage Δ
pkg/service/vm.go 0.00% <0.00%> (ø)
controllers/elfcluster_controller.go 69.58% <100.00%> (+0.57%) ⬆️
controllers/elfmachine_controller.go 74.80% <100.00%> (+0.13%) ⬆️
...ntrollers/elfmachine_controller_placement_group.go 72.07% <100.00%> (ø)

jessehu
jessehu reviewed Sep 14, 2023
View reviewed changes
config/manager/manager.yaml
@@ -18,7 +18,6 @@ spec:
containers:
- args:
- --leader-elect
- --logtostderr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个--logtostderr参数不需要了？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.3-to-v1.4.html?highlight=logtostderr#other

main.go Outdated
"max-concurrent-vm-creations",
config.MaxConcurrentVMCreations,

fs.IntVar(&elfClusterConcurrency, "elfcluster-concurrency", 10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elfcluster-concurrency => max-elfcluster-concurrent-reconciles

main.go Outdated
fs.IntVar(&elfClusterConcurrency, "elfcluster-concurrency", 10,
"Number of ELF clusters to process simultaneously")

fs.IntVar(&elfMachineConcurrency, "elfmachine-concurrency", 10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elfmachine-concurrency => max-elfmachine-concurrent-reconciles

jessehu
jessehu approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@jessehu jessehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@haijianyang haijianyang merged commit 2a179dd into smartxworks:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessehu jessehu jessehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haijianyang @jessehu