Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GPU #146

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add support for GPU #146

merged 4 commits into from
Sep 27, 2023

Conversation

haijianyang
Copy link
Contributor

@haijianyang haijianyang commented Sep 19, 2023

增加 GPU 支持

设计文档

TODO:

  • 优化分配 GPU 的逻辑

测试

测试环境:2GPU 直通集群

  • 并发创建 1 CP + 15Worker 集群,正常创建 2Works 挂载了指定的 GPU,其他 Workers 等待 GPU,没有出现 GPU 冲突。

@haijianyang haijianyang requested a review from jessehu September 19, 2023 05:50
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #146 (deba631) into master (2a179dd) will increase coverage by 0.84%.
The diff coverage is 61.99%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   55.97%   56.82%   +0.84%     
==========================================
  Files          16       17       +1     
  Lines        2744     3157     +413     
==========================================
+ Hits         1536     1794     +258     
- Misses       1073     1207     +134     
- Partials      135      156      +21     
Files Coverage Δ
controllers/vm_limiter.go 100.00% <100.00%> (ø)
pkg/service/collections.go 96.51% <100.00%> (+0.26%) ⬆️
pkg/service/util.go 30.32% <87.50%> (+8.62%) ⬆️
pkg/service/errors.go 0.00% <0.00%> (ø)
controllers/elfmachine_controller.go 72.87% <29.54%> (-1.93%) ⬇️
controllers/elfmachine_controller_gpu.go 82.91% <82.91%> (ø)
pkg/service/vm.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

api/v1beta1/elfmachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/types.go Show resolved Hide resolved
controllers/elfmachine_controller.go Show resolved Hide resolved
controllers/elfmachine_controller.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller_gpu.go Outdated Show resolved Hide resolved
pkg/service/util.go Outdated Show resolved Hide resolved
pkg/service/vm.go Outdated Show resolved Hide resolved
api/v1beta1/conditions_consts.go Outdated Show resolved Hide resolved
controllers/vm_limiter_test.go Outdated Show resolved Hide resolved
@haijianyang haijianyang merged commit 763aae8 into smartxworks:master Sep 27, 2023
3 checks passed
@jessehu jessehu changed the title [WIP] Add support for GPU Add support for GPU Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants