Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKS-1914: Add WaitingForPlacementGroupPolicySatisfied and WaitingForELFClusterWithSufficientMemory reasons #150

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

haijianyang
Copy link
Contributor

@haijianyang haijianyang commented Oct 17, 2023

增加 reasons 方便通过 ElfMachine 了解更多VM无法Ready的错误信息。

新增以下两个 reasons 用于反馈 ELF 集群内存不足和放置组策略不能满足。

  • WaitingForELFClusterWithSufficientMemory
  • WaitingForPlacementGroupPolicySatisfied

其他需要反馈但已有的 reasons :

  • ShuttingDownFailedReason
  • PoweringOffFailedReason
  • PoweringOnFailedReason
  • WaitingForAvailableHostRequiredByPlacementGroupReason
  • JoiningPlacementGroupFailedReason
  • WaitingForAvailableHostWithEnoughGPUsReason
  • AttachingGPUFailedReason
  • DetachingGPUFailedReason

@haijianyang haijianyang requested a review from jessehu October 17, 2023 07:25
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #150 (a0eaae5) into master (f855a41) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   56.77%   56.82%   +0.05%     
==========================================
  Files          17       17              
  Lines        3160     3164       +4     
==========================================
+ Hits         1794     1798       +4     
  Misses       1210     1210              
  Partials      156      156              
Files Coverage Δ
controllers/tower_cache.go 87.34% <100.00%> (+0.67%) ⬆️

@haijianyang haijianyang temporarily deployed to default October 17, 2023 08:48 — with GitHub Actions Inactive
@haijianyang haijianyang merged commit d1d3614 into smartxworks:master Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants