SKS-2157: Cache placement group to reduce Tower API requests #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 59.35% 59.58% +0.23%
==========================================
Files 19 19
Lines 3523 3556 +33
==========================================
+ Hits 2091 2119 +28
- Misses 1283 1288 +5
Partials 149 149 ☔ View full report in Codecov by Sentry. |
jessehu
reviewed
Dec 5, 2023
jessehu
reviewed
Dec 6, 2023
controllers/vm_limiter.go
Outdated
| @@ -38,7 +38,7 @@ const ( | |||
| placementGroupSilenceTime = time.Minute * 5 | |||
| ) | |||
|
|
|||
| var vmTaskErrorCache = cache.New(5*time.Minute, 10*time.Minute) | |||
| var memoryCache = cache.New(5*time.Minute, 10*time.Minute) | |||
There was a problem hiding this comment.
memoryCache -> inMemoryCache
|
更新验证结果和最新讨论。剩余问题可以等 SDK 处理，或者另外单独处理。 |
jessehu
approved these changes
Dec 7, 2023
这个问题，记个ticket 放到1.3处理吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
在一个SKS创建的所有工作负载集群包含一百几十个节点的环境中，获取Tower放置组API的调用量会很大（包含 CAPE 和其他的方式的）。
CAPE 每个节点关联了一个放置组，放置组是节点组之间共享的。
当前每个节点 Reconcile 的时候都会通过 Tower API 获取放置组的信息（两次），一次是确认放置组是否存在，一次是确认节点对应的虚拟机是否还在放置组。
CAPE 默认 10-15m 就 resync，这个时候所有的节点都会 Reconcile 一次，也就意味着需要从 Tower 获取两次放置组信息，这样会重复从 Tower 获取放置组信息。
Change
多个节点是共享放置组的，所以放置组读多写少，考虑使用缓存，减少对 Tower API 的访问。
如果修改了放置组，需要及时删除放置组缓存。并且在删除放置组的时候也应该马上删除放置组缓存，防止马上创建同名放置组的时候使用到过期的缓存。
Test
连续八次通过 E2E
优化前：
优化后：
出现突然访问暴增的原因是 Tower 服务不可用（例如更新、重启等）。Tower 不可用之后，调用 Tower 接口马上就返回 503 了，所以很快，导致 CAPE 不断的退避重试（此时缓存可能无效）。
相关讨论 slack。访问突然暴增的问题可以不在当前 PR 处理。