Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarty5 #852

Merged
merged 153 commits into from
Aug 7, 2023
Merged

Smarty5 #852

merged 153 commits into from
Aug 7, 2023

Conversation

wisskid
Copy link
Contributor

@wisskid wisskid commented Jan 24, 2023

No description provided.

@wisskid
WIP converting code to PSR-4
91b6fde
@wisskid
More PSR4 rewriting
8b5540f
@wisskid
Removed autoload filters
e54a533
@wisskid
WIP making compile classes PSR-4
53fe73b
@wisskid
WIP making compile classes PSR-4
9a0d46f
@wisskid
Replace Smarty:: with symfony/polyfill-mbstring
d0319bd
@wisskid
WIP making compile classes PSR-4
164a89a
@wisskid
finished rewriting all compile classes into PSR-4
1524f11
@wisskid
Rewrote all Compile and Compiler classes to PSR-4
6ba059d
@wisskid
WIP rewriting smarty_internal_method_*
5cac5e4
@wisskid
Finished moving smarty_internal_method_*
b0db470
@wisskid
smarty_internal_resource_* to PSR-4
cfd8c08
@wisskid
Refactored all _runtime_* by merging them into the proper classes or …
d88175d 
…by transforming them into Runtime Extensions.
@wisskid
src/Template/* to PSR-4
0fc2b37
@wisskid
src/sysplugins/* to PSR-4
f1e7b2d
@wisskid
Entire src dir now PSR-4 compatible
4d66910
@wisskid
Add makefile, PSR-4 ModifierCompilers
57cff64
@wisskid
Rewrote all default modifiers and functions from the plugins folder t…
ab5705a 
…o PSR-4 classes
@wisskid
Rewrote remaining plugins to PSR-4, plugins dir is now gone.
6b9e2fa
@wisskid
WIP moving Smarty to PSR-4.
60a5696
@wisskid
fixed pre/post/output filters and removed some old todo-comments
b9ecf11
@wisskid
filter tests passing
9766aba
@wisskid
Fixed TemplateObject test
98ad1a1
@wisskid
Fix CustomResourceAmbiguousTest
32df4c6
@wisskid
Fixed CacheResource implementation and tests
3fccb54
@wisskid
Fixed setfilter
16c7fe1
@wisskid
Fixed DefaultPluginHandlerTest for function plugins (blocks still break)
41054cf
@wisskid
move runPluginFromDefaultHandler to new Runtime class
14bbffd
@wisskid
Introduce formatParamsArray method for recurring code fragment
216347b
@wisskid
Fix code duplication in block compilers and fix (most) BlockPluginTes…
3cc6113 
…ts. Default plugin handler blocks still need fixing.
@wisskid
Fixed markdown syntax. Fixes #879
cea303d
@wisskid
Added full support and documentation for ternary operator.
81cda9e 
Fixes #881
@wisskid
updated changelog
b972bb5
@wisskid
fixed error in the mkdocs TOC
7fa8db3
@wisskid
Added support for null coalescing operator
e99d2fa 
Fixes #882
@wisskid
Add docs for null coalescing
f7868b4
@wisskid
more docs
41962d5
@wisskid
Improved docs on compile checking and inheritance
4550bd8
@wisskid
Rewrote docs on filters and resources.
86b7d45
@wisskid
Add makefile entries for generating docs
019fe3f
@wisskid
Docs on caching
8492bf5
@wisskid
finished docs on security and extending smarty
d8b4496
@wisskid
Added Smarty::setExtensions(), fixed unit test for the null coalescin…
90bb78f 
…g operator. Updated docs about registering a custom extension.
@wisskid
updated todos
92736c1
@wisskid
fix template invalidation when migrating to 5.0
dc46052
@wisskid
Merge branch 'master' into smarty5
7a6cbca
@wisskid
remove docs from 'all' to prevent CI build from failing
077df8a
@wisskid
Missed part of commit e751655 in the merge.
515c14b
@wisskid
Missed part of commit a3cbdc4 in the merge
3750c64
@wisskid
Some more missed commits
0750fd7
@wisskid wisskid merged commit 8fd949a into master Aug 7, 2023
9 checks passed
@wisskid
Copy link
Contributor Author

wisskid commented Aug 7, 2023

@wisskid As soon as there is an alpha on https://packagist.org/packages/smarty/smarty, we'll set up a branch to do a daily test upgrade of sites like doc.tiki.org

@marclaporte see https://packagist.org/packages/smarty/smarty#v5.0.0-rc1

Let me know if it behaves

@deltragon
Copy link

I just wanted to say that this looks amazing, and I am excited for it! Thank you for your hard work!

davidbuzz
davidbuzz reviewed Aug 10, 2023
View reviewed changes
Copy link

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok.

@marclaporte
Copy link
Contributor

@wisskid As soon as there is an alpha on https://packagist.org/packages/smarty/smarty, we'll set up a branch to do a daily test upgrade of sites like doc.tiki.org

@marclaporte see https://packagist.org/packages/smarty/smarty#v5.0.0-rc1

Let me know if it behaves

Work started!
https://gitlab.com/tikiwiki/tiki/-/merge_requests/3529/

Feedback forthcoming.

Thanks!!!

@marclaporte
Copy link
Contributor

For the record, @rodriguezny @kambereBr and @jacob-js started working on the next steps of the Smarty 5 and Tiki integration.

@marclaporte
Copy link
Contributor

We'll continue the updates here: #920

@glensc
Copy link
Contributor

glensc commented Jul 26, 2024

what makes smarty 5? release notes doesn't describe anything...

is there a blog post?

@marclaporte
Copy link
Contributor

I am not aware of a blog post, but you can learn more in discussions:

I can tell you it's a huge step forward. Tiki Wiki CMS Groupware uses Tiki since 2002, and we are very happy with Smarty 5. Details: #920

Congrats and thank you to @wisskid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbuzz davidbuzz davidbuzz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wisskid @scottchiefbaker @rudiedirkx @lkppo @marclaporte @deltragon @glensc @davidbuzz