basic json resemble #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2018 13:48
|
Thanks @pschuegr ! I'll take a look. Stay tuned... |
|
@pschuegr - I've got some commits to add to the good work you've begun. Could you give me permission to push to your fork? |
|
@pschuegr - I got carried away (forgot that you said you were planning on error handling). Anyway, does this jive with what you were hoping for? |
|
Yeah, that looks great if you are happy with it 👍 |
|
Thanks @pschuegr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #25
Sorry for the delay! I just dug up my old code and tweaked it a bit. If this seems like a reasonable approach to you, I'll handle the errors properly.