Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShouldNotEqual and ShouldNotBeNil to not rely on its counterpart #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions equality.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,10 @@ func ShouldEqual(actual any, expected ...any) string {
return shouldEqual(actual, expected[0])
}
func shouldEqual(actual, expected any) string {
for _, spec := range equalitySpecs {
if !spec.assertable(actual, expected) {
continue
}
if spec.passes(actual, expected) {
return success
}
break
if passesEqualitySpecs(actual, expected) {
return success
}

renderedExpected, renderedActual := render.Render(expected), render.Render(actual)
if renderedActual == renderedExpected {
message := fmt.Sprintf(shouldHaveBeenEqualButTypeDiff, renderedExpected, renderedActual)
Expand All @@ -42,14 +37,32 @@ func shouldEqual(actual, expected any) string {
return serializer.serializeDetailed(expected, actual, message)
}

// Helper function to check if the actual and expected values pass the equality specs
func passesEqualitySpecs(actual, expected any) bool {
for _, spec := range equalitySpecs {
if !spec.assertable(actual, expected) {
continue
}
if spec.passes(actual, expected) {
return true
}
break
}

return false
}

// ShouldNotEqual receives exactly two parameters and does an inequality check.
// See ShouldEqual for details on how equality is determined.
// See passesEqualitySpecs for details on how equality is determined.
func ShouldNotEqual(actual any, expected ...any) string {
if fail := need(1, expected); fail != success {
return fail
} else if ShouldEqual(actual, expected[0]) == success {
if message := need(1, expected); message != success {
return message
}

if passesEqualitySpecs(actual, expected[0]) {
return fmt.Sprintf(shouldNotHaveBeenEqual, actual, expected[0])
}

return success
}

Expand Down Expand Up @@ -251,7 +264,7 @@ func interfaceHasNilValue(actual any) bool {
func ShouldNotBeNil(actual any, expected ...any) string {
if fail := need(0, expected); fail != success {
return fail
} else if ShouldBeNil(actual) == success {
} else if actual == nil || interfaceHasNilValue(actual) {
return fmt.Sprintf(shouldNotHaveBeenNil, actual)
}
return success
Expand Down