Updating to containerize the app for Docker #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-kuhn
suggested changes
Apr 23, 2017
Dockerfile
Outdated
|
|
||
| RUN apt-get update | ||
| RUN apt-get install yarn | ||
| RUN apt-get update && apt-get install apt-transport-https |
There was a problem hiding this comment.
We should no longer need this line because apt-transport-https is purely for getting yarn.
There was a problem hiding this comment.
@zachary-kuhn You're absolutely right haha.
|
I'll play around this and look into maybe just having a |
|
@zachary-kuhn I made some changes. Let me know what you think. |
leeallen337
force-pushed
the
update/docker-files
branch
3 times, most recently
from
a016d1d to
770d96b
Compare
leeallen337
changed the title
Dockerfile
zachary-kuhn
approved these changes
Apr 28, 2017
… are now self-contained, update README.md
leeallen337
force-pushed
the
update/docker-files
branch
from
291fa92 to
184e009
Compare
mweslander
reviewed
Apr 28, 2017
| ports: | ||
| - '8080:8080' | ||
| - "8080:8080" |
There was a problem hiding this comment.
Why change this to double quotes and above to single? Will one or the other not work?
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY?
The official docker NodeJS images include
yarnso there is no longer a need to install it in theDockerfileReferences:
WHAT?
yarnin the `Dockerfile (it's included in the Node images now)Dockerfilewould only work when you were running the service withdocker-composesince you had a shared volume between your host machine and the container, but if you just tried to build the image and then tried to run it it would fail because in the build process no source code was moved into the container.nodeimage to the latest LTS slim image.apt-get updateandapt-get installon the same line concatenated with&&to take advantage of docker caching and proper cache-busting. Refer to theRunsection here.node_modules,node,yarn, etc.) except maybegitand a text editor.