Unburden zotero's servers in case

[oneyb]

made it quicker to retry installation in case something goes wrong and remove the burden from the zotero server

Updated the copyright year

[smathot]

Thanks for this. However, wouldn't this break when the temporary file does exist, but is corrupted, for example because the previous download attempt aborted halfway?

[oneyb]

Hmm. Good point. I believe this work is delegated to wget. One could also add an sum check (eg md5), because a version is specified. That is a hash would be hard-coded in this script, which would compared to the hash of the downloaded tarball. This would mildly improve security as well. Make sense?

[oneyb]

That's what I mean. I tested both downloads (which one should automate).

Zotero doesn't explicitly support this:
https://forums.zotero.org/discussion/70280/checksum-to-verify-download-integrity

I think they should...
Trust is good, testing is better.
(Vertrauen ist gut, Kontrolle ist besser.)

[smathot]

This indeed goes some way to checking the integrity. However, there are a few issues:

• It would take me extra time because I'd have to explicitly look up the checksums for each update
• If the file is corrupted, it isn't downloaded again, but rather the installation is aborted. This is especially problematic when the script is automatically executed in the context of an Ubuntu repository, because the user won't have any idea of what went wrong.

The last issue is solvable, but the first probably isn't. So, while I appreciate the idea, I'm afraid that I'm not inclined to merge these changes.