Fill libs dependency scope

smecalculus · Oct 14, 2023 · 50ec5f9 · 50ec5f9
1 parent 22e164d
commit 50ec5f9
Show file tree

Hide file tree

Showing 9 changed files with 65 additions and 32 deletions.
diff --git a/libs/abstraction-client/pom.xml b/libs/abstraction-client/pom.xml
@@ -16,6 +16,7 @@
     <dependency>
       <groupId>jakarta.validation</groupId>
       <artifactId>jakarta.validation-api</artifactId>
+      <scope>compile</scope>
     </dependency>
   </dependencies>
 

diff --git a/libs/abstraction/pom.xml b/libs/abstraction/pom.xml
@@ -16,6 +16,7 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>abstraction-client</artifactId>
+      <scope>compile</scope>
     </dependency>
   </dependencies>
 </project>
diff --git a/libs/essentials/pom.xml b/libs/essentials/pom.xml
@@ -17,6 +17,7 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>abstraction</artifactId>
+      <scope>compile</scope>
     </dependency>
     <!--VALIDATION-->
     <dependency>
@@ -33,28 +34,34 @@
     <dependency>
       <groupId>com.typesafe</groupId>
       <artifactId>config</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.yaml</groupId>
       <artifactId>snakeyaml</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <!--LOGGING-->
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <!--CONSTRUCTION-->
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-context</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot</artifactId>
+      <scope>compile</scope>
     </dependency>
   </dependencies>
 </project>
diff --git a/libs/essentials/src/main/java/smecalculus/bezmen/construction/ConfigBeans.java b/libs/essentials/src/main/java/smecalculus/bezmen/construction/ConfigBeans.java
@@ -16,14 +16,14 @@ public class ConfigBeans {
     @Bean
     @ConditionalOnConfigProtocolMode(ConfigProtocolMode.FILE_SYSTEM)
     @ConditionalOnConfigMappingMode(ConfigMappingMode.LIGHTBEND_CONFIG)
-    PropsKeeper configKeeperLightbendConfig() {
+    PropsKeeper propsKeeperLightbendConfig() {
         return new PropsKeeperLightbendConfig(ConfigFactory.load());
     }
 
     @Bean
     @ConditionalOnConfigProtocolMode(ConfigProtocolMode.FILE_SYSTEM)
     @ConditionalOnConfigMappingMode(ConfigMappingMode.SPRING_CONFIG)
-    PropsKeeper configKeeperSpringConfig(Environment environment) {
+    PropsKeeper propsKeeperSpringConfig(Environment environment) {
         return new PropsKeeperSpringConfig(environment);
     }
 }
diff --git a/libs/messaging-client/pom.xml b/libs/messaging-client/pom.xml
@@ -17,11 +17,13 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>abstraction-client</artifactId>
+      <scope>compile</scope>
     </dependency>
     <!--SERDE-->
     <dependency>
       <groupId>com.fasterxml.jackson.core</groupId>
       <artifactId>jackson-databind</artifactId>
+      <scope>compile</scope>
     </dependency>
     <!--TESTING-->
     <dependency>

diff --git a/libs/messaging/pom.xml b/libs/messaging/pom.xml
@@ -14,48 +14,48 @@
 
   <dependencies>
     <!--CORE-->
-    <dependency>
-      <groupId>${project.groupId}</groupId>
-      <artifactId>messaging-client</artifactId>
-    </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>essentials</artifactId>
+      <scope>compile</scope>
     </dependency>
     <!--MAPPING-->
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-webmvc</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>com.fasterxml.jackson.core</groupId>
-      <artifactId>jackson-core</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>com.fasterxml.jackson.core</groupId>
       <artifactId>jackson-databind</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <!--HTTP-->
     <dependency>
       <groupId>org.eclipse.jetty</groupId>
       <artifactId>jetty-servlets</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.eclipse.jetty</groupId>
       <artifactId>jetty-webapp</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <!--CONSTRUCTION-->
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-autoconfigure</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-actuator</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework.boot</groupId>
       <artifactId>spring-boot-actuator-autoconfigure</artifactId>
+      <scope>compile</scope>
       <exclusions>
         <exclusion>
           <groupId>com.fasterxml.jackson.datatype</groupId>

diff --git a/libs/pom.xml b/libs/pom.xml
@@ -29,6 +29,7 @@
     <spring-data.version>3.1.4</spring-data.version>
     <jetty.version>11.0.17</jetty.version>
     <jackson.version>2.15.3</jackson.version>
+    <junit.version>5.10.0</junit.version>
     <mockito.version>5.6.0</mockito.version>
     <skipTests>false</skipTests>
     <skipUnits>${skipTests}</skipUnits>
@@ -121,11 +122,6 @@
         <version>1.4.11</version>
       </dependency>
 
-      <dependency>
-        <groupId>com.fasterxml.jackson.core</groupId>
-        <artifactId>jackson-core</artifactId>
-        <version>${jackson.version}</version>
-      </dependency>
       <dependency>
         <groupId>com.fasterxml.jackson.core</groupId>
         <artifactId>jackson-databind</artifactId>
@@ -263,10 +259,15 @@
         <version>2.2.224</version>
       </dependency>
 
+      <dependency>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter-api</artifactId>
+        <version>${junit.version}</version>
+      </dependency>
       <dependency>
         <groupId>org.junit.jupiter</groupId>
         <artifactId>junit-jupiter-engine</artifactId>
-        <version>5.10.0</version>
+        <version>${junit.version}</version>
       </dependency>
       <dependency>
         <groupId>org.junit.platform</groupId>
@@ -370,17 +371,6 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>
           <version>3.3.0</version>
-          <executions>
-            <execution>
-              <id>exterior-jar</id>
-              <configuration>
-                <classifier>client</classifier>
-                <includes>
-                  <include>**/exterior/**</include>
-                </includes>
-              </configuration>
-            </execution>
-          </executions>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
@@ -475,6 +465,7 @@
           <configuration>
             <rules>
               <banDuplicatePomDependencyVersions/>
+              <requireExplicitDependencyScope/>
               <requireProfileIdsExist/>
               <dependencyConvergence/>
               <requireUpperBoundDeps/>

diff --git a/libs/storage/pom.xml b/libs/storage/pom.xml
@@ -16,36 +16,43 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>essentials</artifactId>
+      <scope>compile</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.springframework</groupId>
+      <artifactId>spring-beans</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-jdbc</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework.data</groupId>
       <artifactId>spring-data-jdbc</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.mybatis</groupId>
       <artifactId>mybatis</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.mybatis</groupId>
       <artifactId>mybatis-spring</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.postgresql</groupId>
       <artifactId>postgresql</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>com.h2database</groupId>
       <artifactId>h2</artifactId>
+      <scope>runtime</scope>
     </dependency>
-    <dependency>
-      <groupId>org.springframework</groupId>
-      <artifactId>spring-beans</artifactId>
-    </dependency>
-
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>testing</artifactId>

diff --git a/libs/testing/pom.xml b/libs/testing/pom.xml
@@ -16,62 +16,86 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>abstraction-client</artifactId>
+      <scope>compile</scope>
     </dependency>
 
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-context</artifactId>
+      <scope>runtime</scope>
     </dependency>
 
     <dependency>
       <groupId>org.liquibase</groupId>
       <artifactId>liquibase-core</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-jdbc</artifactId>
+      <scope>runtime</scope>
     </dependency>
 
     <dependency>
       <groupId>jakarta.servlet</groupId>
       <artifactId>jakarta.servlet-api</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.reactivestreams</groupId>
       <artifactId>reactive-streams</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>io.projectreactor</groupId>
       <artifactId>reactor-core</artifactId>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.springframework</groupId>
+      <artifactId>spring-web</artifactId>
+      <scope>compile</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-webflux</artifactId>
+      <scope>runtime</scope>
     </dependency>
 
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-api</artifactId>
+      <scope>compile</scope>
+    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-engine</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.junit.platform</groupId>
       <artifactId>junit-platform-suite</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.assertj</groupId>
       <artifactId>assertj-core</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.mockito</groupId>
       <artifactId>mockito-core</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.awaitility</groupId>
       <artifactId>awaitility</artifactId>
+      <scope>runtime</scope>
     </dependency>
     <dependency>
       <groupId>org.springframework</groupId>
       <artifactId>spring-test</artifactId>
+      <scope>compile</scope>
     </dependency>
   </dependencies>