Rename ListOpenFilesResponse proto msg field to totalOpenKeyCount…

… for consistency.
smengcl · Jan 9, 2024 · ca910f7 · ca910f7
1 parent 96d1747
commit ca910f7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...ava/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java b/...ava/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
@@ -1815,7 +1815,7 @@ public ListOpenFilesResult listOpenFiles(String path,
     return new ListOpenFilesResult(resp.getClientIDList(),
         resp.getKeyInfoList(),
         resp.getHasMore(),
-        resp.getGlobalTotal());
+        resp.getTotalOpenKeyCount());
   }
 
   @Override

diff --git a/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto b/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
@@ -1537,8 +1537,8 @@ message ListOpenFilesRequest {
 
 message ListOpenFilesResponse {
   // size of openKeyTable and openFileTable combined
-  optional uint64 globalTotal = 1;  // TODO: Rename to totalOpenKeyCount
-  // if true, indicates that there are remaining entries under the path
+  optional uint64 totalOpenKeyCount = 1;
+  // indicates if there are more entries to be retrieved under the given path
   optional bool hasMore = 2;
   // result
   repeated uint64 clientID = 3;

diff --git a/...-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java b/...-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
@@ -939,7 +939,7 @@ private ListOpenFilesResponse listOpenFiles(ListOpenFilesRequest req,
         impl.listOpenFiles(req.getPath(), req.getCount(), req.getToken());
     // TODO: Avoid unnecessary ser-de?
 
-    resp.setGlobalTotal(res.getTotalOpenKeyCount());
+    resp.setTotalOpenKeyCount(res.getTotalOpenKeyCount());
     resp.setHasMore(res.hasMore());
 
     for (OpenKeySession e : res.getOpenKeys()) {