Address https://github.com/apache/ozone/pull/5167/files#r1289538750

smengcl · Aug 10, 2023 · d058d50 · d058d50
1 parent 55b932f
commit d058d50
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 26 deletions.
diff --git a/...zone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java b/...zone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
@@ -151,10 +151,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       omMetrics.incNumKeyCommits();
     }
 
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("isHSync = {}, volumeName = {}, bucketName = {}, keyName = {}",
-          isHSync, volumeName, bucketName, keyName);
-    }
+    LOG.debug("isHSync = {}, volumeName = {}, bucketName = {}, keyName = {}",
+        isHSync, volumeName, bucketName, keyName);
 
     try {
       commitKeyArgs = resolveBucketLink(ozoneManager, commitKeyArgs, auditMap);
@@ -324,11 +322,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       processResult(commitKeyRequest, volumeName, bucketName, keyName,
           omMetrics, exception, omKeyInfo, result);
     } else {
-      // Debug logging for HSync
-      if (LOG.isDebugEnabled()) {
-        LOG.debug("Key successfully committed with isHSync = {}, " +
-            "omKeyInfo = {}", isHSync, omKeyInfo);
-      }
+      // Debug logging for HSync key commits
+      LOG.debug("Key successfully committed with isHSync = {}, " +
+          "omKeyInfo = {}", isHSync, omKeyInfo);
     }
 
     return omClientResponse;

diff --git a/...nager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java b/...nager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java
@@ -108,10 +108,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       omMetrics.incNumKeyCommits();
     }
 
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("isHSync = {}, volumeName = {}, bucketName = {}, keyName = {}",
-          isHSync, volumeName, bucketName, keyName);
-    }
+    LOG.debug("isHSync = {}, volumeName = {}, bucketName = {}, keyName = {}",
+        isHSync, volumeName, bucketName, keyName);
 
     OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
 
@@ -279,11 +277,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       processResult(commitKeyRequest, volumeName, bucketName, keyName,
           omMetrics, exception, omKeyInfo, result);
     } else {
-      // Debug logging for HSync
-      if (LOG.isDebugEnabled()) {
-        LOG.debug("Key successfully committed with isHSync = {}, " +
-            "omKeyInfo = {}", isHSync, omKeyInfo);
-      }
+      // Debug logging for HSync key commits
+      LOG.debug("Key successfully committed with isHSync = {}, " +
+          "omKeyInfo = {}", isHSync, omKeyInfo);
     }
 
     return omClientResponse;

diff --git a/...zone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java b/...zone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
@@ -863,10 +863,8 @@ protected OmKeyInfo wrapUncommittedBlocksAsPseudoKey(
   protected void filterOutBlocksStillInUse(OmKeyInfo referenceKey,
                                            RepeatedOmKeyInfo keysToBeFiltered) {
 
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("Before block filtering, keysToBeFiltered = {}",
-          keysToBeFiltered);
-    }
+    LOG.debug("Before block filtering, keysToBeFiltered = {}",
+        keysToBeFiltered);
 
     // A HashSet for fast lookup. Gathers all ContainerBlockID entries inside
     // the referenceKey.
@@ -944,9 +942,7 @@ protected void filterOutBlocksStillInUse(OmKeyInfo referenceKey,
       }
     }
 
-    if (LOG.isDebugEnabled()) {
-      LOG.debug("After block filtering,  keysToBeFiltered = {}",
-          keysToBeFiltered);
-    }
+    LOG.debug(" After block filtering, keysToBeFiltered = {}",
+        keysToBeFiltered);
   }
 }