Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r2r from 0.8 to 0.9 #50

Merged
merged 2 commits into from
May 21, 2024
Merged

Update r2r from 0.8 to 0.9 #50

merged 2 commits into from
May 21, 2024

Conversation

taiki-e
Copy link

@taiki-e taiki-e commented May 20, 2024

No description provided.

@taiki-e taiki-e closed this May 20, 2024
@taiki-e taiki-e reopened this May 20, 2024
@taiki-e taiki-e marked this pull request as ready for review May 20, 2024 10:24
```
error: assigning the result of `Clone::clone()` may be inefficient
   --> tf_rosrust/src/tf_buffer.rs:158:21
    |
158 |                     first = intermediate.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `first.clone_from(&intermediate)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `-D clippy::assigning-clones` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`
```
@taiki-e taiki-e requested a review from OTL May 20, 2024 10:37
@taiki-e taiki-e enabled auto-merge (rebase) May 20, 2024 10:37
@taiki-e taiki-e merged commit 00f11b1 into main May 21, 2024
6 checks passed
@taiki-e taiki-e deleted the taiki-e/r2r branch May 21, 2024 05:52
@taiki-e taiki-e mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants