-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use nullable types for all structure members (Java, .NET) #496
base: main-1.x
Are you sure you want to change the base?
Conversation
Marking this as ready for review despite the unrelated failing CI test (something to do with a Rust-related patch not applying, which we believe is due to unintended nondeterminism in the module order emitted by the Dafny-to-Rust compiler). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving an initial blocking review just because I'm not worried that this isn't correct for Smithy 1.0 models, that the better fix is to support @box consistently (it is supported for Java but not .NET AFAICT)
…lexchew/wip-fix-optional-primitives # Conflicts: # TestModels/SimpleTypes/SimpleBoolean/codegen-patches/rust/dafny-4.5.0.patch # codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithydotnet/AwsSdkDotNetNameResolver.java
An issue with going to down further down this path is that Smithy-Dafny is forking the Smithy 1.0 Specification. Smithy-Dafny could argue that such a change in behavior is necessary to support the Local Service Trait; A stronger argument, in favor of the box approach, |
Issue #, if available: #278
Description of changes: Changes the .NET and Java code generators to use nullable types for all structure members (even required members with primitive-equivalent shapes).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.