Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] WIP "safe sed" for Python/Go/Rust #511

Closed
wants to merge 1 commit into from

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Aug 12, 2024

Issue #, if available:

Description of changes:

Tested with 2 TestModels (Boolean + Blob) and the MPL (all subprojects + test vectors).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucasmcdonald3 lucasmcdonald3 changed the title wip [DRAFT] WIP "safe sed" for Python/Go/Rust Aug 12, 2024
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Go perspective. I’ve been just dropping the . from the externs so this change would require some refactor but this is what we want long term.

@rishav-karanjit
Copy link
Member

LGTM from Go perspective. I’ve been just dropping the . from the externs so this change would require some refactor but this is what we want long term.

@ShubhamChaturvedi7 And I have been reverting your dropped . lol

@lucasmcdonald3
Copy link
Contributor Author

Closing in favor of #512
Let's get this into main. Python can pull this in from main.

@lucasmcdonald3 lucasmcdonald3 deleted the python-sed branch August 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants