Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Python): Restrict poetry-core to <2.0.0 #757

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Jan 6, 2025

Issue #, if available:

Description of changes:

poetry released a new major version: https://pypi.org/project/poetry/2.0.0/
Python projects picked this up automatically because they didn't specify a maximum version for poetry.
This is bad, since this is a breaking change, and it broke building new Python libraries.
This doesn't break customers using already-distributed Smithy-Dafny Python projects. This only breaks the build system, and we only rebuild the library in CI and for releases. I can install and use (ex.) the published Crypto Tools MPL without issues.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review January 6, 2025 20:32
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner January 6, 2025 20:32
@lucasmcdonald3 lucasmcdonald3 merged commit 0c07997 into main-1.x Jan 6, 2025
86 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the fix-python branch January 6, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants